Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Pydantic v2 migration #6578

Merged
merged 80 commits into from
Nov 21, 2024
Merged

⬆️ Pydantic v2 migration #6578

merged 80 commits into from
Nov 21, 2024

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 22, 2024 •
edited by pcrespov
Loading

What do these changes do?

This PR contains all the changes to migrate osparc-simcore to pydantic V2.

It can only be merged once all the services are migrated!

Related issue/s

How to test

Dev-ops checklist

giancarloromeo and others added 16 commits September 18, 2024 11:45
@giancarloromeo @GitHK
⬆️ Upgrade models-library (pydantic v2) (#6333)
d2d81c0 
Co-authored-by: Andrei Neagu <[email protected]>
@giancarloromeo
♻️ Add common library (#6495)
19e3923
@giancarloromeo
⬆️ Upgrade libraries (pydantic v2) (#6366)
1d92881
@giancarloromeo
Upgrade agent service (Pydantic v2) (#6508)
329b00d
@giancarloromeo
Upgrade EFS guardian service (Pydantic v2) (#6516)
6786b92
@giancarloromeo
Upgrade invitations service (Pydantic v2) (#6513)
bbe92a2
@giancarloromeo
Upgrade clusters keeper service (Pydantic v2) (#6519)
42c0a68
@sanderegg
Merge remote-tracking branch 'origin/master' into pydantic_v2_migrati…
1c833e0 
…on_do_not_squash_updates
@sanderegg
♻️Pydantic V2 upgrade: autoscaling (#6535)
cac8134
@GitHK @sanderegg
🎨 pydantic2 migration: fixed unit-tests for dynamic-sidecar (#6534)
e97258e 
Co-authored-by: Andrei Neagu <[email protected]>
@GitHK @sanderegg
🎨 pydantic2 migration: fixed unit-tests for dynamic-scheduler (#6547)
463488b 
Co-authored-by: Andrei Neagu <[email protected]>
@GitHK @sanderegg
🎨 pydantic2 migration: fixed unit-tests for agent (#6546)
c2b4983 
Co-authored-by: Andrei Neagu <[email protected]>
@GitHK @sanderegg
🎨 pydantic2 migration: fixed unit-tests for payments (#6553)
64293f0 
Co-authored-by: Andrei Neagu <[email protected]>
@giancarloromeo @sanderegg
Upgrade resource usage tracker (Pydantic v2) (#6517)
cf5546b
@sanderegg
Merge remote-tracking branch 'origin/master' into pydantic_v2_migrati…
3b188f5 
…on_do_not_squash_updates
@sanderegg
Merge remote-tracking branch 'origin/master' into pydantic_v2_migrati…
4716e55 
…on_do_not_squash_updates
@sanderegg sanderegg added a:storage issue related to storage service a:webserver issue related to the webserver service a:services-library issues on packages/service-libs a:database associated to postgres service and postgres-database package t:maintenance Some planned maintenance work e2e Bugs found by or related to the end-2-end testing a:catalog catalog service a:director-v2 issue related with the director-v2 service a:apiserver api-server service a:dynamic-sidecar dynamic-sidecar service a:dask-service Any of the dask services: dask-scheduler/sidecar or worker a:models-library a:autoscaling autoscaling service in simcore's stack a:ooil integration-library or ooil labels Oct 22, 2024
pcrespov and others added 12 commits November 19, 2024 10:51
@pcrespov
⬆️♻️ Fix/test models (#6758)
c10d7d0
@giancarloromeo
♻️ Greenify pylint (after Pydantic v2 migration) (#6747)
3250e5d
@bisgaard-itis
🎨 Ensure profiling middleware is compatible with fastapi (#6760)
dcdc863
@sanderegg
♻️Pydantic V2: Unify errors dv 2 (#6763)
c50d79c
@pcrespov
Uses typing_extensions.TypedDict in all instances used in pydantic mo…
0aea337 
…dels AND fixes with migration of rest_ordering (#6770)
@giancarloromeo
♻️ Cleanup network AnyHttpUrlLegacy and HttpUrlLegacy (#6767)
c49f421
@GitHK
All errors in dynamic-sidecar inherit from OsparcErrorMixin (#6764)
a0b8a2f 
Co-authored-by: Andrei Neagu <[email protected]>
@giancarloromeo
♻️ Fix agent tests (#6772)
66a492f
@pcrespov
Fixes [unit] webserver 03 and [unit] settings-library (both mypy and …
c38b064 
…tests) (#6773)
@sanderegg
Merge remote-tracking branch 'upstream/master' into update-master-XXXXX
150b17a
@sanderegg
Merge pull request #6780 from sanderegg/update-master-XXXXX
17d1702 
⬆️Pydantic V2L Update from upstream/master
@sanderegg
⬆️Pydantic V2: missing import in director-v0 (#6781)
47e3570
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 20, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.5% Duplication on New Code

See analysis details on SonarQube Cloud

@giancarloromeo giancarloromeo marked this pull request as ready for review November 21, 2024 08:32
GitHK
GitHK approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally green! Looking forward to seeing this in master

pcrespov
pcrespov approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

mrnicegyu11
mrnicegyu11 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jesus, TL;DR!

but damn, thank you guys to much for pushing this!

matusdrobuliak66
matusdrobuliak66 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@giancarloromeo giancarloromeo changed the title ⬆️Pydantic v2 migration do not squash updates (🚨🚨🚨🚨🚨🚨🚨) ⬆️ Pydantic v2 migration Nov 21, 2024
@giancarloromeo giancarloromeo merged commit 5732a12 into master Nov 21, 2024
128 of 153 checks passed
@pcrespov pcrespov mentioned this pull request Nov 21, 2024
Closed
4 tasks
@sanderegg sanderegg deleted the pydantic_v2_migration_do_not_squash_updates branch November 22, 2024 08:56
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 26, 2024
Closed
18 tasks
@giancarloromeo giancarloromeo mentioned this pull request Nov 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@GitHK GitHK GitHK approved these changes

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@YuryHrytsuk YuryHrytsuk Awaiting requested review from YuryHrytsuk YuryHrytsuk is a code owner

Assignees

@giancarloromeo giancarloromeo

@GitHK GitHK

@pcrespov pcrespov

@sanderegg sanderegg

@matusdrobuliak66 matusdrobuliak66

@bisgaard-itis bisgaard-itis

Labels
a:agent agent service a:apiserver api-server service a:autoscaling autoscaling service in simcore's stack a:aws-library a:catalog catalog service a:clusters-keeper a:dask-service Any of the dask services: dask-scheduler/sidecar or worker a:database associated to postgres service and postgres-database package a:datcore-adapter a:director-v2 issue related with the director-v2 service a:dynamic-scheduler a:dynamic-sidecar dynamic-sidecar service a:invitations invitations service a:models-library a:notifications-library a:ooil integration-library or ooil a:osparc-gateway-server a:payments payments service a:resource-usage-tracker resource usage tracker service a:services-library issues on packages/service-libs a:simcore-sdk a:storage issue related to storage service a:webserver issue related to the webserver service computational clusters dependencies Pull requests that update a dependency file e2e Bugs found by or related to the end-2-end testing efs-guardian t:maintenance Some planned maintenance work
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.

Major upgrade to pydantic 2.0
7 participants
@sanderegg @giancarloromeo @GitHK @mrnicegyu11 @pcrespov @matusdrobuliak66 @bisgaard-itis