♻️ aiohttp deprecation: Using web.json_response to return 2XX responses instead of raising HttpException

[pcrespov]

What do these changes do?

aiohttp deprecated returning HttpException. Moreover, raising non-error creates false negatives as in the example below where 204 (No Content) was shown as an error in our tracing

• ♻️This PR uses web.json_response to return 2XX responses instead of raising HttpException
• ♻️ Updates status code helpers and consistency between aiohttp.web_exceptions and servicelib.aiohttp.status codes (taken over from WIP: 🎨 Enh/error handler 500 #5487).

Related issue/s

• Maintenance

How to test

• in place

Dev-ops checklist

None

[codecov]

Codecov Report

Attention: Patch coverage is 92.92929% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.1%. Comparing base (cafbf96) to head (2bdcd5b).
Report is 655 commits behind head on master.

Files with missing lines	Patch %	Lines
...core_service_webserver/projects/_nodes_handlers.py	55.5%	4 Missing ⚠️
...imcore_service_webserver/publications/_handlers.py	50.0%	1 Missing ⚠️
...er/src/simcore_service_webserver/tags/_handlers.py	50.0%	1 Missing ⚠️
...service_webserver/users/_notifications_handlers.py	75.0%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #6563      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.5%     
=========================================
  Files          10    1553    +1543     
  Lines         214   63560   +63346     
  Branches       25    2078    +2053     
=========================================
+ Hits          181   56014   +55833     
- Misses         23    7229    +7206     
- Partials       10     317     +307     

Flag	Coverage Δ
integrationtests	64.7% <41.6%> (?)
unittests	86.1% <92.9%> (+1.5%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...c/servicelib/aiohttp/long_running_tasks/_routes.py	100.0% <100.0%> (ø)
...e-library/src/servicelib/aiohttp/rest_responses.py	85.2% <100.0%> (ø)
...src/servicelib/aiohttp/web_exceptions_extension.py	100.0% <100.0%> (ø)
...rvice-library/src/servicelib/status_codes_utils.py	86.3% <100.0%> (ø)
...rage/src/simcore_service_storage/handlers_files.py	99.2% <100.0%> (ø)
...src/simcore_service_storage/handlers_simcore_s3.py	100.0% <100.0%> (ø)
...rc/simcore_service_webserver/api_keys/_handlers.py	92.1% <100.0%> (ø)
...simcore_service_webserver/director_v2/_handlers.py	91.8% <100.0%> (ø)
...ore_service_webserver/folders/_folders_handlers.py	93.6% <100.0%> (ø)
.../src/simcore_service_webserver/groups/_handlers.py	82.8% <100.0%> (ø)
... and 18 more

... and 1474 files with indirect coverage changes

[mrnicegyu11]

lgtm thanks a lot, also for explaining the background behind this

[matusdrobuliak66]

Thanks! 👍

[sanderegg]

thanks

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud