Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Tests bad parsing of jobs custom metadata #6559

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Oct 18, 2024

What do these changes do?

Testing that issue #6556 is not caused on the server side. The problem seems to be related with how the osparc python client serializes the values of the custom metadata.

Probably the client does not use strict types when it serializes the update_metadata body.
image

Will follow up with a fix in the client in PR ITISFoundation/osparc-simcore-clients#192

Related issue/s

How to test

cd services/api-server
make install-dev
pytest -v test_models_schema_jobs

Dev-ops checklist

None

@pcrespov pcrespov self-assigned this Oct 18, 2024
@pcrespov pcrespov added this to the MartinKippenberger milestone Oct 18, 2024
@pcrespov pcrespov added the a:apiserver api-server service label Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.8%. Comparing base (cafbf96) to head (37e1c06).
Report is 648 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6559      +/-   ##
=========================================
- Coverage    84.5%   66.8%   -17.8%     
=========================================
  Files          10     686     +676     
  Lines         214   33537   +33323     
  Branches       25     265     +240     
=========================================
+ Hits          181   22410   +22229     
- Misses         23   11066   +11043     
- Partials       10      61      +51     
Flag Coverage Δ
integrationtests 64.7% <ø> (?)
unittests 89.8% <100.0%> (+5.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../simcore_service_api_server/models/schemas/jobs.py 96.5% <100.0%> (ø)

... and 695 files with indirect coverage changes

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pcrespov pcrespov merged commit 91ca56e into ITISFoundation:master Oct 18, 2024
57 checks passed
@pcrespov pcrespov deleted the is6556/api-metadata-wrong-return branch October 18, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants