-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Tests bad parsing of jobs custom metadata #6559
♻️ Tests bad parsing of jobs custom metadata #6559
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6559 +/- ##
=========================================
- Coverage 84.5% 66.8% -17.8%
=========================================
Files 10 686 +676
Lines 214 33537 +33323
Branches 25 265 +240
=========================================
+ Hits 181 22410 +22229
- Misses 23 11066 +11043
- Partials 10 61 +51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
What do these changes do?
Testing that issue #6556 is not caused on the server side. The problem seems to be related with how the osparc python client serializes the values of the custom metadata.
Probably the client does not use strict types when it serializes the
update_metadata
body.Will follow up with a fix in the client in PR ITISFoundation/osparc-simcore-clients#192
Related issue/s
How to test
Dev-ops checklist
None