Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 pydantic2 migration: fixed unit-tests for payments #6553

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 17, 2024

What do these changes do?

  • migrated entire service to pydantic2
  • removed all pydantic2 deprecation warnings

@pcrespov since you are the owner of the service please keep an extra eye open to make sure I did not break anything

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Oct 17, 2024
@GitHK GitHK added t:maintenance Some planned maintenance work a:payments payments service labels Oct 17, 2024
@GitHK GitHK added this to the MartinKippenberger milestone Oct 17, 2024
@GitHK GitHK changed the title 🎨 pydantic2 payments 🎨 pydantic2 migration: fixed unit-tests for agent Oct 17, 2024
@GitHK GitHK changed the title 🎨 pydantic2 migration: fixed unit-tests for agent 🎨 pydantic2 migration: fixed unit-tests for payments Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (pydantic_v2_migration@b9a27e8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../simcore_service_payments/db/auto_recharge_repo.py 75.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             pydantic_v2_migration   #6553   +/-   ##
=======================================================
  Coverage                         ?   84.0%           
=======================================================
  Files                            ?     813           
  Lines                            ?   28739           
  Branches                         ?    1809           
=======================================================
  Hits                             ?   24151           
  Misses                           ?    4287           
  Partials                         ?     301           
Flag Coverage Δ
unittests 84.0% <98.3%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../src/models_library/api_schemas_payments/errors.py 96.0% <100.0%> (ø)
...settings-library/src/settings_library/utils_cli.py 86.3% <ø> (ø)
...vices/payments/src/simcore_service_payments/cli.py 100.0% <100.0%> (ø)
...yments/src/simcore_service_payments/core/errors.py 90.9% <100.0%> (ø)
...ents/src/simcore_service_payments/core/settings.py 100.0% <100.0%> (ø)
...mcore_service_payments/db/payments_methods_repo.py 87.5% <100.0%> (ø)
..._service_payments/db/payments_transactions_repo.py 87.5% <100.0%> (ø)
...payments/src/simcore_service_payments/models/db.py 100.0% <100.0%> (ø)
...s/src/simcore_service_payments/models/db_to_api.py 92.8% <ø> (ø)
...imcore_service_payments/models/payments_gateway.py 100.0% <100.0%> (ø)
... and 7 more

@GitHK GitHK marked this pull request as ready for review October 18, 2024 09:56
@GitHK GitHK requested a review from giancarloromeo October 18, 2024 09:57
Copy link

@GitHK GitHK merged commit fbf9fa9 into ITISFoundation:pydantic_v2_migration Oct 18, 2024
44 of 58 checks passed
@GitHK GitHK deleted the pr-osparc-pydantic2-payments2 branch October 18, 2024 13:30
sanderegg pushed a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:payments payments service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants