-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 pydantic2 migration: fixed unit-tests for payments #6553
Merged
GitHK
merged 17 commits into
ITISFoundation:pydantic_v2_migration
from
GitHK:pr-osparc-pydantic2-payments2
Oct 18, 2024
Merged
🎨 pydantic2 migration: fixed unit-tests for payments #6553
GitHK
merged 17 commits into
ITISFoundation:pydantic_v2_migration
from
GitHK:pr-osparc-pydantic2-payments2
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHK
added
t:maintenance
Some planned maintenance work
a:payments
payments service
labels
Oct 17, 2024
GitHK
changed the title
🎨 pydantic2 payments
🎨 pydantic2 migration: fixed unit-tests for agent
Oct 17, 2024
GitHK
changed the title
🎨 pydantic2 migration: fixed unit-tests for agent
🎨 pydantic2 migration: fixed unit-tests for payments
Oct 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pydantic_v2_migration #6553 +/- ##
=======================================================
Coverage ? 84.0%
=======================================================
Files ? 813
Lines ? 28739
Branches ? 1809
=======================================================
Hits ? 24151
Misses ? 4287
Partials ? 301
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…-osparc-pydantic2-payments2
…-osparc-pydantic2-payments2
GitHK
requested review from
pcrespov,
matusdrobuliak66 and
sanderegg
as code owners
October 18, 2024 09:56
sanderegg
approved these changes
Oct 18, 2024
Quality Gate passedIssues Measures |
GitHK
merged commit Oct 18, 2024
fbf9fa9
into
ITISFoundation:pydantic_v2_migration
44 of 58 checks passed
sanderegg
pushed a commit
that referenced
this pull request
Oct 22, 2024
Co-authored-by: Andrei Neagu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
@pcrespov since you are the owner of the service please keep an extra eye open to make sure I did not break anything
Related issue/s
How to test
Dev-ops checklist