-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ 📝 Minor refactor and doc of autoscaling
service
#6551
♻️ 📝 Minor refactor and doc of autoscaling
service
#6551
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6551 +/- ##
=========================================
+ Coverage 84.5% 87.5% +2.9%
=========================================
Files 10 1256 +1246
Lines 214 54886 +54672
Branches 25 1243 +1218
=========================================
+ Hits 181 48035 +47854
- Misses 23 6641 +6618
- Partials 10 210 +200
Flags with carried forward coverage won't be shown. Click here to find out more.
|
866757a
to
deb557f
Compare
autoscaling
service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not just a documentation refactor it's change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the first draft, but an empty EC2_INSTANCES_ALLOWED_TYPES means that no type is allowed. What your change does is to accept anything, which goes against how the system works.
services/autoscaling/src/simcore_service_autoscaling/core/settings.py
Outdated
Show resolved
Hide resolved
services/autoscaling/src/simcore_service_autoscaling/modules/auto_scaling_core.py
Outdated
Show resolved
Hide resolved
services/autoscaling/src/simcore_service_autoscaling/modules/auto_scaling_core.py
Outdated
Show resolved
Hide resolved
services/autoscaling/src/simcore_service_autoscaling/modules/auto_scaling_core.py
Outdated
Show resolved
Hide resolved
services/autoscaling/src/simcore_service_autoscaling/modules/auto_scaling_core.py
Outdated
Show resolved
Hide resolved
services/autoscaling/tests/unit/test_modules_auto_scaling_core.py
Outdated
Show resolved
Hide resolved
@sanderegg As I mentioned above in the description, this behaviour was already like this. I found it strange but I just did not want to change the logic. Now i see that probably you were not aware of this issue so let me show you and we can change it |
59a70da
to
d2b2485
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great thanks!
services/autoscaling/src/simcore_service_autoscaling/modules/auto_scaling_core.py
Outdated
Show resolved
Hide resolved
services/autoscaling/src/simcore_service_autoscaling/modules/auto_scaling_core.py
Outdated
Show resolved
Hide resolved
services/autoscaling/src/simcore_service_autoscaling/modules/auto_scaling_core.py
Show resolved
Hide resolved
dc22713
to
c899568
Compare
Quality Gate passedIssues Measures |
What do these changes do?
Minor refactor and documentation update for
autoscaling
serviceget_ec2_instance_capabilities
to guarantee a sorted return value.EC2_INSTANCES_ALLOWED_TYPE
is empty.Related issue/s
How to test
Dev-ops checklist
None