Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Sim4Life computational jobs are not parented correctly #6542

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 15, 2024

What do these changes do?

Issue: the project metadata are not set correctly in the comp_runs table when sim4life runs a job

Observations:

  • Tried to reproduce the issue using a Jupyterlab and running the osparc client to no avail, it works there properly,
  • Tried to add the exact same metadata and it still works.

Actions:

  • added a debug log to see if the call in the director-v2 is doing some weird behavior.
  • improved testing in dv-2 regarding metadata

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label Oct 15, 2024
@sanderegg sanderegg added this to the MartinKippenberger milestone Oct 15, 2024
@sanderegg sanderegg self-assigned this Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.1%. Comparing base (cafbf96) to head (2b3df56).
Report is 644 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6542      +/-   ##
=========================================
- Coverage    84.5%   68.1%   -16.5%     
=========================================
  Files          10     604     +594     
  Lines         214   30656   +30442     
  Branches       25     265     +240     
=========================================
+ Hits          181   20895   +20714     
- Misses         23    9700    +9677     
- Partials       10      61      +51     
Flag Coverage Δ
integrationtests 64.7% <100.0%> (?)
unittests 84.0% <100.0%> (-0.6%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ore_service_director_v2/api/routes/computations.py 84.0% <100.0%> (ø)
...e_director_v2/modules/db/repositories/comp_runs.py 94.9% <100.0%> (ø)

... and 612 files with indirect coverage changes

@sanderegg sanderegg force-pushed the bugfix/parent-project-not-transfered branch from 561a633 to b0bb5c1 Compare October 17, 2024 07:48
@sanderegg sanderegg changed the title Bugfix/parent project not transfered Sim4Life computational jobs are not parented correctly Oct 17, 2024
@sanderegg sanderegg changed the title Sim4Life computational jobs are not parented correctly ♻️Sim4Life computational jobs are not parented correctly Oct 17, 2024
@sanderegg sanderegg marked this pull request as ready for review October 17, 2024 07:52
Copy link

@mguidon
Copy link
Member

mguidon commented Oct 17, 2024

Just fyi: s4l in prod is still using custom meta data fields for this. Not the headers.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IF I understand this correctly, you still did not manage to find the cause for the bug and this is just adding some loggers to get more info in the master deployment.

@sanderegg sanderegg merged commit 380f606 into ITISFoundation:master Oct 17, 2024
57 checks passed
@sanderegg
Copy link
Member Author

IF I understand this correctly, you still did not manage to find the cause for the bug and this is just adding some loggers to get more info in the master deployment.

yes

@sanderegg sanderegg deleted the bugfix/parent-project-not-transfered branch October 17, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants