-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️Sim4Life computational jobs are not parented correctly #6542
♻️Sim4Life computational jobs are not parented correctly #6542
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6542 +/- ##
=========================================
- Coverage 84.5% 68.1% -16.5%
=========================================
Files 10 604 +594
Lines 214 30656 +30442
Branches 25 265 +240
=========================================
+ Hits 181 20895 +20714
- Misses 23 9700 +9677
- Partials 10 61 +51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
561a633
to
b0bb5c1
Compare
Quality Gate passedIssues Measures |
Just fyi: s4l in prod is still using custom meta data fields for this. Not the headers. |
services/director-v2/src/simcore_service_director_v2/modules/db/repositories/comp_runs.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/db/repositories/comp_runs.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IF I understand this correctly, you still did not manage to find the cause for the bug and this is just adding some loggers to get more info in the master
deployment.
services/director-v2/src/simcore_service_director_v2/modules/db/repositories/comp_runs.py
Show resolved
Hide resolved
yes |
What do these changes do?
Issue: the project metadata are not set correctly in the comp_runs table when sim4life runs a job
Observations:
Actions:
Related issue/s
How to test
Dev-ops checklist