Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade resource usage tracker (Pydantic v2) #6517

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix url
  • Loading branch information
giancarloromeo committed Oct 14, 2024
commit 468576ce674c25bae70db7dc52f601d6e847032a
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ async def export_service_runs(
access_all_wallet_usage: bool = False,
order_by: OrderBy | None = None,
filters: ServiceResourceUsagesFilters | None = None,
) -> AnyUrl:
) -> str:
app_settings: ApplicationSettings = app.state.settings
s3_settings = app_settings.RESOURCE_USAGE_TRACKER_S3
assert s3_settings # nosec
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ async def export_service_runs(
access_all_wallet_usage: bool = False,
order_by: OrderBy | None = None,
filters: ServiceResourceUsagesFilters | None = None,
) -> AnyUrl:
) -> str:
started_from = filters.started_at.from_ if filters else None
started_until = filters.started_at.until if filters else None

Expand All @@ -177,7 +177,7 @@ async def export_service_runs(
)

# Create presigned S3 link
generated_url: AnyUrl = await s3_client.create_single_presigned_download_link(
generated_url: str = await s3_client.create_single_presigned_download_link(
bucket=s3_bucket_name,
object_key=s3_object_key,
expiration_secs=_PRESIGNED_LINK_EXPIRATION_SEC,
Expand Down
Loading