-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π¨ EFS Guardian: adding size monitoring #6502
π¨ EFS Guardian: adding size monitoring #6502
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6502 +/- ##
=========================================
+ Coverage 84.5% 88.1% +3.5%
=========================================
Files 10 1546 +1536
Lines 214 63324 +63110
Branches 25 2059 +2034
=========================================
+ Hits 181 55807 +55626
- Misses 23 7199 +7176
- Partials 10 318 +308
Flags with carried forward coverage won't be shown. Click here to find out more.
|
β¦mcore into improve-efs-2
services/efs-guardian/src/simcore_service_efs_guardian/core/settings.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, please check some of my suggestions
services/efs-guardian/src/simcore_service_efs_guardian/services/efs_manager_utils.py
Show resolved
Hide resolved
services/efs-guardian/src/simcore_service_efs_guardian/services/process_messages.py
Outdated
Show resolved
Hide resolved
services/efs-guardian/src/simcore_service_efs_guardian/services/process_messages_setup.py
Outdated
Show resolved
Hide resolved
services/efs-guardian/src/simcore_service_efs_guardian/services/background_tasks.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR
- the dy-sidecar notifies
DynamicServiceRunningMessage
and the efs-guardian listens - efs-guardian:
- prepares background modules (still not fully implemented) which needs redis for distributed lock mechanism
EfsManager
operates on EFS mounted folder. I understand is a "single drive" and you only manipulate one project/node at a time?- process-messages reacts to a service running. If size is over threshold, it remove write premssions. Uses redis as a distributed lock mechanims here as well.
Generally, I think you should give a deeper thought about including good testing and error handling.
services/efs-guardian/src/simcore_service_efs_guardian/services/modules/redis.py
Show resolved
Hide resolved
services/efs-guardian/src/simcore_service_efs_guardian/services/background_tasks_setup.py
Outdated
Show resolved
Hide resolved
services/efs-guardian/src/simcore_service_efs_guardian/services/background_tasks_setup.py
Outdated
Show resolved
Hide resolved
services/efs-guardian/src/simcore_service_efs_guardian/services/background_tasks.py
Outdated
Show resolved
Hide resolved
services/efs-guardian/src/simcore_service_efs_guardian/services/efs_manager_utils.py
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
What do these changes do?
Related issue/s
How to test
Dev-ops checklist