-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] S4L and S4L lite: Include deprecated versions in plus button, they should all be updatable to a non deprecated one #6480
Merged
odeimaiz
merged 4 commits into
ITISFoundation:master
from
odeimaiz:enh/include-deprecated-in-plus-button
Oct 1, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
Improvement or request on an existing feature
a:frontend
issue affecting the front-end (area group)
labels
Oct 1, 2024
odeimaiz
changed the title
🎨 [Frontend] S4L: Include deprecated versions in plus button, they should all be updatable to a non deprecated one
🎨 [Frontend] S4L and S4L lite: Include deprecated versions in plus button, they should all be updatable to a non deprecated one
Oct 1, 2024
GitHK
approved these changes
Oct 1, 2024
pcrespov
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ignapas
approved these changes
Oct 1, 2024
Quality Gate passedIssues Measures |
jsaq007
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Oct 2, 2024
…ould all be updatable to a non deprecated one (ITISFoundation#6480)
16 tasks
This was referenced Oct 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a:frontend
issue affecting the front-end (area group)
t:enhancement
Improvement or request on an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
At the moment, if the service that the plus button points to is deprecated (defined in the
new_studies.json
), the plus button will not be shown.Since we want to be very flexible, and deprecate the old versions only in some cases, this PR changes that behaviour. We assume that the deprecated service will have an updatable non deprecated key/version.
Related issue/s
How to test
Dev-ops checklist