Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [Frontend] S4L and S4L lite: Include deprecated versions in plus button, they should all be updatable to a non deprecated one #6480

Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 1, 2024

What do these changes do?

At the moment, if the service that the plus button points to is deprecated (defined in the new_studies.json), the plus button will not be shown.

Since we want to be very flexible, and deprecate the old versions only in some cases, this PR changes that behaviour. We assume that the deprecated service will have an updatable non deprecated key/version.

PlusButton

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 1, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Oct 1, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) October 1, 2024 09:22
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 1, 2024
@odeimaiz odeimaiz changed the title 🎨 [Frontend] S4L: Include deprecated versions in plus button, they should all be updatable to a non deprecated one 🎨 [Frontend] S4L and S4L lite: Include deprecated versions in plus button, they should all be updatable to a non deprecated one Oct 1, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

sonarqubecloud bot commented Oct 1, 2024

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@odeimaiz odeimaiz merged commit 25a2fd0 into ITISFoundation:master Oct 1, 2024
51 checks passed
@odeimaiz odeimaiz deleted the enh/include-deprecated-in-plus-button branch October 1, 2024 12:36
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants