Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨📝 Misc improvements in tooling and doc #6478

Merged
merged 4 commits into from
Oct 1, 2024
Merged

🔨📝 Misc improvements in tooling and doc #6478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aab527f
renamed and doc recipe to download registry test-data
pcrespov Oct 1, 2024
03331f6
highlights host name in email
pcrespov Oct 1, 2024
58944c9
fixes autoscaled-monitor exception not handled
pcrespov Oct 1, 2024
682c3c1
Merge branch 'master' into mai/minor-misc
pcrespov Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/models-library/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,15 @@ erd-ServiceInput.svg: _erdantic
DOWNLOADED_TEST_DATA_DIR = "$(CURDIR)/tests/data/.downloaded-ignore"

.PHONY: _httpx
_httpx: _check_venv_active
_ensure_httpx: _check_venv_active
# ensures requirements installed
@python3 -c "import httpx" 2>/dev/null || uv pip install httpx

PHONY: pull_test_data
pull_test_data: $(DOT_ENV_FILE) _httpx ## downloads tests data from registry (this can take some time!)
# downloading all metadata files
PHONY: tests-data
tests-data: $(DOT_ENV_FILE) _ensure_httpx ## downloads tests data from registry defined in .env (time-intensive!)
# Downloading all metadata files ...
@set -o allexport; \
source $<; \
set +o allexport; \
python3 "$(PACKAGES_DIR)/pytest-simcore/src/pytest_simcore/helpers/docker_registry.py" $(DOWNLOADED_TEST_DATA_DIR)
@echo "Run now 'pytest -vv -m diagnostics tests'"
2 changes: 1 addition & 1 deletion ...ifications-library/src/notifications_library/templates/on_account_form.email.content.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<p>Dear Support team

<p>
We have received the following request form for an account in {{ product.display_name }} from {{ host }}
We have received the following request form for an account in {{ product.display_name }} from <b>{{ host }}</b>
</p>

<pre>
Expand Down
2 changes: 1 addition & 1 deletion ...tifications-library/src/notifications_library/templates/on_account_form.email.content.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Dear Support team,

We have received the following request form for an account in {{ product.display_name }} from {{ host }}:
We have received the following request form for an account in {{ product.display_name }} from **{{ host }}**:

{{ dumps(request_form) }}

Expand Down
5 changes: 3 additions & 2 deletions scripts/maintenance/computational-clusters/autoscaled_monitor/dask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,13 @@ def _list_tasks(

return dict(task_state_to_tasks)

list_of_tasks: dict[TaskState, list[TaskId]] = []
try:
list_of_tasks: dict[TaskState, list[TaskId]] = await client.run_on_scheduler(
list_of_tasks = await client.run_on_scheduler(
_list_tasks
) # type: ignore
except TypeError:
rich.print(f"ERROR while recoverring unrunnable tasks using {dask_client=}")
rich.print(f"ERROR while recoverring unrunnable tasks using {dask_client=}. Defaulting to empty list of tasks!!")
return list_of_tasks


Expand Down
Loading