Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Access Full TIP #6423

Merged
merged 9 commits into from
Sep 23, 2024
Merged

🎨 [Frontend] Access Full TIP #6423

merged 9 commits into from
Sep 23, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 23, 2024 •
edited
Loading

What do these changes do?

  • Move button from Navigation bar to User menu
  • Rename to Access Full TIP
  • TIP lite logo:
    • Add Tooltip: "This is TIP lite, a light version of TIP. Request access to TIP."
    • Pop up same teaser when tapping

Bonus:

  • Remove "Choose Plan in pop-up" description text from main Plus button

AccessFullTIP

Related issue/s

related to ITISFoundation/osparc-issues#1701

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Sep 23, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Sep 23, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 23, 2024
@odeimaiz odeimaiz marked this pull request as ready for review September 23, 2024 09:07
@odeimaiz odeimaiz enabled auto-merge (squash) September 23, 2024 09:24
jsaq007
jsaq007 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pcrespov
pcrespov reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz merged commit 6f680c9 into ITISFoundation:master Sep 23, 2024
51 checks passed
matusdrobuliak66 pushed a commit that referenced this pull request Sep 23, 2024
@odeimaiz @matusdrobuliak66
🎨 [Frontend] Access Full TIP (#6423)
cd8a2b8
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Sep 25, 2024
@odeimaiz @jsaq007
🎨 [Frontend] Access Full TIP (ITISFoundation#6423)
3613041
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
@odeimaiz @mrnicegyu11
🎨 [Frontend] Access Full TIP (ITISFoundation#6423)
fcc7b78
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 4, 2024
Closed
16 tasks
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@calys calys Awaiting requested review from calys

@GitHK GitHK Awaiting requested review from GitHK

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @jsaq007 @ignapas @pcrespov