Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Frontend] Workspaces & Folders: Merge Workspace header and Folder breadcrumbs #6414

Merged
merged 11 commits into from
Sep 23, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 20, 2024

What do these changes do?

One of the coming feature requests will make the Search bar search projects across all workspaces and folders.

Therefore, the Search bar needs to go over Workspace header. And since now the Workspace header and Folder breadcrumbs were very close from each other, it was decided to merge them and show the breadcrumbs right after the workspace title. All the functionality to change context were kept.

Before:
image

After:
image

Related issue/s

related to #6405
related to ITISFoundation/osparc-issues#716

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Sep 20, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 20, 2024
@odeimaiz odeimaiz changed the title ✨ [Frontend] Search bar should search projects across all folders ✨ [Frontend] Folders & Workspaces: Merge Workspace header and breadcrumbs Sep 23, 2024
@odeimaiz odeimaiz changed the title ✨ [Frontend] Folders & Workspaces: Merge Workspace header and breadcrumbs ✨ [Frontend] Workspaces & Folders: Merge Workspace header and Folder breadcrumbs Sep 23, 2024
@odeimaiz odeimaiz marked this pull request as ready for review September 23, 2024 08:47
Copy link

@odeimaiz odeimaiz merged commit 64d5027 into ITISFoundation:master Sep 23, 2024
51 checks passed
@odeimaiz odeimaiz deleted the enh/search-space branch September 23, 2024 09:47
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Sep 25, 2024
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants