Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding favicon for all devices #6402

Closed
wants to merge 26 commits into from

Conversation

jsaq007
Copy link
Contributor

@jsaq007 jsaq007 commented Sep 19, 2024

What do these changes do?

Fix favicon flickering and wrong favicon when duplicating tab, by including the write favicon in the index.html instead of updating it after loading the page

Favicons

Related issue/s

fixes ITISFoundation/osparc-issues#1716

How to test

Dev-ops checklist

@jsaq007 jsaq007 self-assigned this Sep 19, 2024
odeimaiz and others added 25 commits September 20, 2024 09:05
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pedro Crespo-Valero <[email protected]>
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 89.48220% with 65 lines in your changes missing coverage. Please review.

Project coverage is 88.2%. Comparing base (cafbf96) to head (0bbb563).
Report is 583 commits behind head on master.

Files with missing lines Patch % Lines
...mcore_service_dynamic_sidecar/modules/nodeports.py 23.8% 32 Missing ⚠️
...dynamic_scheduler/services/service_tracker/_api.py 88.5% 13 Missing ⚠️
...-sdk/src/simcore_sdk/node_ports_v2/nodeports_v2.py 52.6% 8 Missing and 1 partial ⚠️
...s/service-library/src/servicelib/services_utils.py 0.0% 4 Missing ⚠️
.../service-library/src/servicelib/aiohttp/tracing.py 66.6% 3 Missing ⚠️
...e_dynamic_scheduler/services/notifier/_notifier.py 87.5% 1 Missing ⚠️
...er/services/status_monitor/_deferred_get_status.py 97.9% 1 Missing ⚠️
...amic_scheduler/services/status_monitor/_monitor.py 98.1% 1 Missing ⚠️
.../modules/attribute_monitor/_watchdog_extensions.py 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6402      +/-   ##
=========================================
+ Coverage    84.5%   88.2%    +3.6%     
=========================================
  Files          10    1525    +1515     
  Lines         214   62762   +62548     
  Branches       25    2029    +2004     
=========================================
+ Hits          181   55382   +55201     
- Misses         23    7067    +7044     
- Partials       10     313     +303     
Flag Coverage Δ
integrationtests 64.7% <64.0%> (?)
unittests 86.2% <89.3%> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._library/api_schemas_dynamic_scheduler/socketio.py 100.0% <100.0%> (ø)
...odels_library/api_schemas_dynamic_sidecar/ports.py 100.0% <100.0%> (ø)
...ls_library/api_schemas_dynamic_sidecar/socketio.py 100.0% <100.0%> (ø)
...ls_library/api_schemas_webserver/projects_nodes.py 97.0% <ø> (ø)
...odels-library/src/models_library/services_enums.py 78.7% <100.0%> (ø)
...models/resource_tracker_pricing_plan_to_service.py 100.0% <ø> (ø)
..._database/models/resource_tracker_pricing_plans.py 100.0% <ø> (ø)
...base/models/resource_tracker_pricing_unit_costs.py 100.0% <ø> (ø)
...se/src/simcore_postgres_database/models/wallets.py 100.0% <ø> (ø)
...src/simcore_postgres_database/models/workspaces.py 100.0% <ø> (ø)
... and 44 more

... and 1423 files with indirect coverage changes

@jsaq007 jsaq007 force-pushed the product-favicons branch 2 times, most recently from d6cfa46 to 0bbb563 Compare September 25, 2024 12:56
Copy link

@jsaq007 jsaq007 closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicating the tab changes its icon
5 participants