🐛⚗️Prometheus instrumentation incorrectly setup

[sanderegg]

What do these changes do?

• since ✨ Add: Tracing via opentelemetry #6168 came in, the unit tests in autoscaling started to fail randomly (for example like this one)

Here is probably what was happening:

• in tests we use asgi-lifespan to emulate what fastapi does (this is how fastapi recommend of doing)
• since the tracing was introduced, it seems that initialization phase in the tests takes longer, and times-out sometimes (default is 5 seconds)
• the prometheus_fastapi_instrumentator library introduced by @bisgaard-itis a long time ago uses a global CollectorRegistry, and is initialized,
• after the time out happen, this is not cleaned up (since global are 👿 ),
• all subsequent tests fail, as the global registry is already full.

This PR does:

• creates a collector registry,
• increases the timeouts in the lifespan manager,
• does some cleaning

Related issue/s

• fixes directorv-2: use a non global registry #6399

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

Attention: Patch coverage is 51.51515% with 16 lines in your changes missing coverage. Please review.

Project coverage is 87.9%. Comparing base (cafbf96) to head (e7cbb8b).
Report is 561 commits behind head on master.

Files with missing lines	Patch %	Lines
...c/servicelib/fastapi/prometheus_instrumentation.py	0.0%	9 Missing ⚠️
.../service-library/src/servicelib/instrumentation.py	0.0%	6 Missing ⚠️
.../service-library/src/servicelib/fastapi/tracing.py	83.3%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #6398      +/-   ##
=========================================
+ Coverage    84.5%   87.9%    +3.3%     
=========================================
  Files          10    1170    +1160     
  Lines         214   51580   +51366     
  Branches       25     930     +905     
=========================================
+ Hits          181   45340   +45159     
- Misses         23    6065    +6042     
- Partials       10     175     +165     

Flag	Coverage Δ
integrationtests	64.7% <100.0%> (?)
unittests	85.4% <51.5%> (+0.8%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...rvice_autoscaling/modules/instrumentation/_core.py	91.6% <100.0%> (ø)
...ice_autoscaling/modules/instrumentation/_models.py	100.0% <100.0%> (ø)
...vice_autoscaling/modules/instrumentation/_utils.py	100.0% <100.0%> (ø)
...ice_director_v2/modules/instrumentation/_models.py	100.0% <100.0%> (ø)
.../service-library/src/servicelib/fastapi/tracing.py	87.5% <83.3%> (ø)
.../service-library/src/servicelib/instrumentation.py	0.0% <0.0%> (ø)
...c/servicelib/fastapi/prometheus_instrumentation.py	0.0% <0.0%> (ø)

... and 1173 files with indirect coverage changes

[matusdrobuliak66]

Thanks a lot!!

[pcrespov]

🎉

[GitHK]

Thanks! Please also apply the same changes to director-v2's metrics module

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[GitHK]

Thanks for the changes!