🚨🐛 Mitigate dy-service file upload bug: Increase traefik timeouts #6395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnicegyu11
added
bug
|
1 similar comment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6395 +/- ##
=========================================
+ Coverage 84.5% 87.9% +3.3%
=========================================
Files 10 1421 +1411
Lines 214 58710 +58496
Branches 25 2070 +2045
=========================================
+ Hits 181 51641 +51460
- Misses 23 6748 +6725
- Partials 10 321 +311
Flags with carried forward coverage won't be shown. Click here to find out more. |
sanderegg
approved these changes
Sep 19, 2024
YuryHrytsuk
approved these changes
Sep 19, 2024
|
Forcemerged as told by @matusdrobuliak66 |
|
I guess it would be wise to write these findings down for the next time this gets upgraded. |
29 tasks
mrnicegyu11
added a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Oct 2, 2024
…ISFoundation#6395) Co-authored-by: Dustin Kaiser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The traefik timeout defaults changed between minor versions 2.10 and 2.11: https://doc.traefik.io/traefik/migration/v2/#v211
This PR also adds the increased timeouts of 6h that have been set in the ops-traefik to the simcore traefik, as dy-services such as S4L do fileupload using a singular POST requests that goes via
client --> ops-traefik -- > simcore-traefik -- > caddy --> nginx. When the REST requests' long-running conenction exceeds60s, traefik>2.10by default severs the connection. Nginx indicates this client disconnect by responding the unique status code499.Related issue/s
How to test
Dev-ops checklist