🐛 Fix aiohttp server autoinstrumentation

[mrnicegyu11]

What do these changes do?

Although after carefully reading all the manuals and docs I am quite sure that my last, big opentelemetry PR has correctly added the opentelemetry-autoinstrumentation-pip-packages for both the aiohttp-client (when an aiohttp server sends RESR requests) and the aiohttp-server (when the aiohttp server recieves REST requests) correctly, the traces in jaeger were incomplete. Those spans relating to the aiohttp-server in the webserver, so e.g. the first REST call from the qooxdoo to the webserver, were missing or disconnected.

Some investigation with the debugger showed that the middleware of the aiohttp-server-autoinstrumentation's middleware was never successfully added to the aoihttp webserver (this: https://github.com/open-telemetry/opentelemetry-python-contrib/blob/08def3e40a72a03afb16f3a6b492663de5252469/instrumentation/opentelemetry-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py#L194 ) . Now, that I add this manual step which the pip package should have done automatically, but dint, maybe simcore somewhere does low-level invasive stuff removing existing middlewares during initialization of the webserver?

This solves the issue, but it is not how the library is intended to be used....

Happy about comments

Update

I have investigated this in-depth and understood why this call is necessary and why it is likely even ok to do so in our case. Thanks for the help @GitHK much appreciated 🙏 ! Please read the comment I have added to the code, and see if this makes it clear / suffces. Thanks!

Related issue/s

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.8%. Comparing base (cafbf96) to head (ebc9e8f).
Report is 633 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #6391      +/-   ##
=========================================
+ Coverage    84.5%   87.8%    +3.2%     
=========================================
  Files          10    1212    +1202     
  Lines         214   52746   +52532     
  Branches       25     950     +925     
=========================================
+ Hits          181   46325   +46144     
- Misses         23    6243    +6220     
- Partials       10     178     +168     

Flag	Coverage Δ
integrationtests	64.7% <ø> (?)
unittests	85.4% <100.0%> (+0.8%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../service-library/src/servicelib/aiohttp/tracing.py	77.1% <100.0%> (ø)

... and 1221 files with indirect coverage changes

[sanderegg]

Please find out why this is happening. and without a hack.
Is this happening also in storage?

[mrnicegyu11]

Please find out why this is happening. and without a hack. Is this happening also in storage?

I dont think I am able to do that on my own :(

[mrnicegyu11]

Anyone feel free to pick this PR up I dont think I want to go down a rabbithole here on my own :--(

[sanderegg]

Anyone feel free to pick this PR up I dont think I want to go down a rabbithole here on my own :--(

For info @mrnicegyu11 I am going through a rabbit hole myself in autoscaling tests that started failing randomly after open telemetry PR went in and finding issues that were unrelated to it. Sometimes one needs to take time, and the time increases with complexity.

[odeimaiz]

It looks like there was a bad merge here. You might not want to touch those frontend files.

[mrnicegyu11]

It looks like there was a bad merge here. You might not want to touch those frontend files.

thanks for catching this, I fixed it please re-review ;) @odeimaiz

[mrnicegyu11]

@sanderegg @pcrespov I added a test as requested, thanks :--) Please re-review

[sanderegg]

all good! thanks!

[pcrespov]

ok

[pcrespov]

FYI: @mrnicegyu11 yet another deprecation warning within opentelemetry

python3.11/site-packages/opentelemetry/instrumentation/dependencies.py:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
    from pkg_resources import (

doesnt apply anymore

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud