Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

βœ… e2e: new workflow to test tiplite #6388

Merged
merged 22 commits into from
Sep 24, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Sep 18, 2024

What do these changes do?

Initial e2e test for tiplite. It executes a variant of "classic TI plan test" implemented for the full tip workflow.

  • 🎨 adds more test-ids to front-end components
  • βœ… adds optional checks on test_classic_ti_plan defined by new is_product_lite fixture
    • checks Access Tip button within menu
    • checks two steps in app-mode
  • ♻️ refactors test fixtures
    • hides secrets in logs
    • cleanup fixture names
  • πŸ“ updated doc
  • ⚠️ After this PR gets merged, we have to merge https://git.speag.com/oSparc/e2e-backend/-/merge_requests/104 to run the e2e-backend in master

Related issue/s

How to test

pytest -s tests/tip --color=yes --browser chromium --headed --product-illable --product-lite --product-url=*** --user-name=*** --password ***

or equivalently

cd tests/e2e-playwright
make test-tip-anywhere

Dev-ops checklist

None

@pcrespov pcrespov self-assigned this Sep 18, 2024
@pcrespov pcrespov added the e2e Bugs found by or related to the end-2-end testing label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 88.1%. Comparing base (cafbf96) to head (3d65081).
Report is 577 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6388      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.5%     
=========================================
  Files          10    1505    +1495     
  Lines         214   62201   +61987     
  Branches       25    2023    +1998     
=========================================
+ Hits          181   54813   +54632     
- Misses         23    7076    +7053     
- Partials       10     312     +302     
Flag Coverage Ξ”
integrationtests 63.5% <ΓΈ> (?)
unittests 86.1% <ΓΈ> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1456 files with indirect coverage changes

@pcrespov pcrespov force-pushed the is1701/new-e2e-tip-lite branch from 0eb2ff7 to da2cfbf Compare September 18, 2024 14:41
@pcrespov pcrespov changed the title WIP: is1701/new-e2e-tip-lite βœ… e2e: new workflow to test tilite Sep 18, 2024
@odeimaiz odeimaiz changed the title βœ… e2e: new workflow to test tilite βœ… e2e: new workflow to test tiplite Sep 19, 2024
@pcrespov pcrespov force-pushed the is1701/new-e2e-tip-lite branch 3 times, most recently from ae819c7 to f4e8892 Compare September 23, 2024 16:05
@pcrespov pcrespov added this to the MartinKippenberger milestone Sep 23, 2024
@pcrespov pcrespov marked this pull request as ready for review September 23, 2024 16:13
@pcrespov pcrespov enabled auto-merge (squash) September 23, 2024 16:14
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pcrespov pcrespov force-pushed the is1701/new-e2e-tip-lite branch from ff317ce to 630443d Compare September 24, 2024 08:01
@pcrespov pcrespov requested a review from sanderegg as a code owner September 24, 2024 08:01
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@pcrespov pcrespov force-pushed the is1701/new-e2e-tip-lite branch from 5ce4912 to 26752c6 Compare September 24, 2024 13:16
@pcrespov pcrespov requested a review from odeimaiz September 24, 2024 13:17
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸͺΆ

@pcrespov pcrespov disabled auto-merge September 24, 2024 15:14
@pcrespov pcrespov merged commit 6fed1f0 into ITISFoundation:master Sep 24, 2024
2 checks passed
Copy link

jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Sep 25, 2024
@pcrespov pcrespov deleted the is1701/new-e2e-tip-lite branch September 25, 2024 15:00
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants