Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨E2E: increase timeout for video streaming and improve a bit logs about websockets #6384

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 17, 2024

What do these changes do?

  • increases the timeout when checking S4l videostreaming to 30 seconds
  • logs warning if the websocket(s) are closed
  • logs error if the websocket(s) have errors

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg self-assigned this Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.2%. Comparing base (cafbf96) to head (eacaac7).
Report is 562 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6384      +/-   ##
=========================================
- Coverage    84.5%   82.2%    -2.4%     
=========================================
  Files          10    1505    +1495     
  Lines         214   62399   +62185     
  Branches       25    2070    +2045     
=========================================
+ Hits          181   51332   +51151     
- Misses         23   10762   +10739     
- Partials       10     305     +295     
Flag Coverage Δ
unittests 82.2% <ø> (-2.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1454 files with indirect coverage changes

@sanderegg sanderegg marked this pull request as ready for review September 18, 2024 15:46
@sanderegg sanderegg changed the title ✨go to 30 ✨E2E: increase timeout for video streaming and improve a bit logs about websockets Sep 18, 2024
@sanderegg sanderegg added t:maintenance Some planned maintenance work e2e Bugs found by or related to the end-2-end testing labels Sep 18, 2024
@sanderegg sanderegg added this to the MartinKippenberger milestone Sep 18, 2024
@sanderegg sanderegg force-pushed the playwright/reconnect-on-websocket-loss branch from 3725c26 to 337f1a2 Compare September 18, 2024 15:50
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx 🙏

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sanderegg sanderegg force-pushed the playwright/reconnect-on-websocket-loss branch from 40157c2 to a1c3329 Compare September 19, 2024 08:16
@sanderegg sanderegg force-pushed the playwright/reconnect-on-websocket-loss branch from a1c3329 to 4134584 Compare September 19, 2024 21:11
@sanderegg sanderegg enabled auto-merge (squash) September 19, 2024 21:24
@sanderegg sanderegg disabled auto-merge September 20, 2024 06:05
Copy link

@sanderegg sanderegg merged commit c28b0da into ITISFoundation:master Sep 20, 2024
54 of 57 checks passed
@sanderegg sanderegg deleted the playwright/reconnect-on-websocket-loss branch September 20, 2024 14:05
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants