Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Frontend] Fix Automatic Shutdown = 0 #6372

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 16, 2024

What do these changes do?

reported by @cosfor1

If, in the user preferences, the "Automatic Shutdown of Idle Instances" is set to 0, the Idling tracker should never start.

Currently, as soon as the service starts, the frontend will ask the backend if it's inactive, the backend will say, "yes, it's inactive", and the frontend will react as the user was Idle, closing the project.

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Sep 16, 2024
@odeimaiz odeimaiz added the bug buggy, it does not work as expected label Sep 16, 2024
@odeimaiz odeimaiz added this to the Doppelbock milestone Sep 16, 2024
@odeimaiz odeimaiz marked this pull request as ready for review September 16, 2024 14:54
@odeimaiz odeimaiz enabled auto-merge (squash) September 16, 2024 14:55
@odeimaiz odeimaiz changed the title 🐛 [Frontend] Fix 🐛 [Frontend] Fix Automatic Shutdown = 0 Sep 16, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Should add @cosfor1 as reviewer? at least for awareness?

@odeimaiz odeimaiz requested a review from cosfor1 September 16, 2024 15:07
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this have anything to do with "Rogue GC" issue?

@odeimaiz
Copy link
Member Author

does this have anything to do with "Rogue GC" issue?

Not that I know of. You would have seen a call to /inactive from the frontend and the backend giving permission to close because the service in the backend was inactive.

Copy link

@odeimaiz odeimaiz merged commit 7f466b5 into ITISFoundation:master Sep 17, 2024
51 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 30, 2024
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants