-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 disk-usage pytest plugin #6196
🔨 disk-usage pytest plugin #6196
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6196 +/- ##
=========================================
+ Coverage 84.5% 88.1% +3.5%
=========================================
Files 10 1463 +1453
Lines 214 60731 +60517
Branches 25 1484 +1459
=========================================
+ Hits 181 53547 +53366
- Misses 23 6871 +6848
- Partials 10 313 +303
Flags with carried forward coverage won't be shown. Click here to find out more. |
I think the culprit is here https://github.com/ITISFoundation/osparc-simcore/actions/runs/10408869816/job/28827529734?pr=6196#step:13:241 This test-suite (i.e. Check all the modules and tests in the CI log starting with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice addition! thanks!
Quality Gate passedIssues Measures |
What do these changes do?
After running out of space in the gh-action machines the CI stops with messages as
This PR implements an optional plugin to monitor disk usage during test execution, identifying tests that do not properly clean up resources. This helps prevent potential issues when running continuous integration (CI) pipelines on external systems, such as GitHub Actions.
The plugin is activated by using the
--disk-usage
option, and it can be configured with a custom threshold using the--disk-usage-threshold
option.Warnings are generated if disk usage increases beyond the specified threshold, allowing for targeted investigation of resource management in specific tests, modules, or the entire test session.
Currently, ONLY activated in integration tests for
Related issue/s
How to test
simcore-sdk/tests
addtest_foo.py
pytest --disk-usage --disk-usage-threshold=1 --log-cli-level=WARNING tests/unit/test_foo.py
Example
in this CI failure