Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ skipping AWS S3 CLI tests #6191

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Aug 15, 2024

What do these changes do?

  • ♻️ skipping heavy integration AWS S3 CLI tests (as we decided we will not use it for now and stay with RClone)

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Aug 15, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review August 15, 2024 11:48
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.5%. Comparing base (cafbf96) to head (a7fcbc0).
Report is 443 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6191      +/-   ##
=========================================
+ Coverage    84.5%   88.5%    +3.9%     
=========================================
  Files          10     942     +932     
  Lines         214   42918   +42704     
  Branches       25     234     +209     
=========================================
+ Hits          181   37998   +37817     
- Misses         23    4858    +4835     
- Partials       10      62      +52     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests 85.6% <ø> (+1.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 952 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just left a suggestion as a comment I think. sorry for that. but please check it it is better than skipping tests altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants