Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑️ Revert traefik v3 #6187

Merged

Conversation

mrnicegyu11
Copy link
Member

What do these changes do?

Reverting the update to traefik v3 since there are more issues that remained undiscovered, and we have maneuvered the team into a position where an urgent release all the way from master to prod is necessary. No time to adress the remaining bugs for the moment.

Related PRs

How to test

Pray it works again.

Dev-ops checklist

@mrnicegyu11 mrnicegyu11 added bug buggy, it does not work as expected High Priority a totally crucial bug/feature to be fixed asap release Preparation for pre-release/release labels Aug 14, 2024
@mrnicegyu11 mrnicegyu11 added this to the Eisbock milestone Aug 14, 2024
@mrnicegyu11 mrnicegyu11 self-assigned this Aug 14, 2024
Copy link

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.1%. Comparing base (cafbf96) to head (feb57ea).
Report is 435 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6187      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.5%     
=========================================
  Files          10    1462    +1452     
  Lines         214   60679   +60465     
  Branches       25    1482    +1457     
=========================================
+ Hits          181   53499   +53318     
- Misses         23    6868    +6845     
- Partials       10     312     +302     
Flag Coverage Δ
integrationtests 65.0% <ø> (?)
unittests 86.1% <ø> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ules/dynamic_sidecar/docker_service_specs/proxy.py 100.0% <ø> (ø)
.../director/src/simcore_service_director/producer.py 66.2% <ø> (ø)

... and 1416 files with indirect coverage changes

@mrnicegyu11 mrnicegyu11 merged commit b1416b4 into ITISFoundation:master Aug 14, 2024
57 checks passed
@sanderegg sanderegg removed the release Preparation for pre-release/release label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected High Priority a totally crucial bug/feature to be fixed asap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants