🐛storage: fixes query to file metadata

[pcrespov]

What do these changes do?

• 🐛 Fixes bug introduced with this change in the database query
• 🐛 Fixes access rights to storage data (in coordination with @matusdrobuliak66 )

Related issue/s

• resolves User cannot download files from file-picker when a project is shared with him/her osparc-issues#1587

How to test

• The changes were driven by to tests in storage, namely
  • Test to check correctness of sql expression (also to print an manually test against master db)
    • pytest -vv tests/unit -k test_building_sql_statements
  • Test to checks different queries in GET locations/{loc_id}/files/metadata
    • pytest -vv tests/unit -k test_get_files_metadata
• Manual exploratory testing using steps in User cannot download files from file-picker when a project is shared with him/her osparc-issues#1587 on a local deploy

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.3%. Comparing base (cafbf96) to head (419da5b).
Report is 438 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #6184      +/-   ##
=========================================
- Coverage    84.5%   66.3%   -18.3%     
=========================================
  Files          10     614     +604     
  Lines         214   31209   +30995     
  Branches       25     234     +209     
=========================================
+ Hits          181   20693   +20512     
- Misses         23   10456   +10433     
- Partials       10      60      +50     

Flag	Coverage Δ
integrationtests	64.8% <ø> (?)
unittests	90.0% <100.0%> (+5.4%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...age/src/simcore_service_storage/db_access_layer.py	88.1% <100.0%> (ø)
...e/src/simcore_service_storage/db_file_meta_data.py	98.5% <100.0%> (ø)
...ices/storage/src/simcore_service_storage/models.py	95.8% <100.0%> (ø)

... and 621 files with indirect coverage changes

[sanderegg]

cool thanks. not sure if that is ready for review. if yes you have my approval

[sanderegg]

Thanks!, please double check the query declaration at global scope

[matusdrobuliak66]

Thanks! looking good.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud