Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Frontend] Fix: exclude the share with product-everyone group for studies #6183

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 13, 2024

What do these changes do?

Spotted by @elisabettai

This PR is a bit of a workaround for a buggy scenario in the DB.

It also fixes the buggy frontend where testers couldn't share a template with the product-everyone.

I'm tester (buggy backend)
Publish

I'm user (buggy backend)
PublishUser

Related issue/s

closes ITISFoundation/osparc-issues#1583

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Aug 13, 2024
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Aug 13, 2024
@odeimaiz odeimaiz added this to the Eisbock milestone Aug 13, 2024
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @odeimaiz and @elisabettai . @elisabettai will also modify the access rigths to the product groups in the database to read=False

Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the quick fix!

@odeimaiz odeimaiz enabled auto-merge (squash) August 13, 2024 15:35
Copy link

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@odeimaiz odeimaiz merged commit 587f744 into ITISFoundation:master Aug 14, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add "Everybody" to template after it has been shared with one or more users
6 participants