Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Frontend] Fix: Credits summary time range #6179

Merged
merged 4 commits into from
Aug 13, 2024
Merged

🐛 [Frontend] Fix: Credits summary time range #6179

merged 4 commits into from
Aug 13, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 13, 2024 •
edited
Loading

What do these changes do?

This PR fixes a small glitch found during the RM presentation. Get rid of the duplicated initial call when opening the Credits Summary.

NoDuplicatedCall

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Aug 13, 2024
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Aug 13, 2024
@odeimaiz odeimaiz added this to the Eisbock milestone Aug 13, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) August 13, 2024 12:20
matusdrobuliak66
matusdrobuliak66 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

sanderegg
sanderegg reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pcrespov
pcrespov reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

jsaq007
jsaq007 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@odeimaiz odeimaiz merged commit 02f7d3f into ITISFoundation:master Aug 13, 2024
55 checks passed
This was referenced Aug 15, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@pcrespov pcrespov pcrespov left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Milestone
Eisbock
Development

Successfully merging this pull request may close these issues.
6 participants
@odeimaiz @jsaq007 @ignapas @pcrespov @sanderegg @matusdrobuliak66