-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fixes cache issue in web-server services i/o model #6176
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6176 +/- ##
=========================================
- Coverage 84.5% 74.7% -9.9%
=========================================
Files 10 347 +337
Lines 214 17260 +17046
Branches 25 0 -25
=========================================
+ Hits 181 12904 +12723
- Misses 23 4356 +4333
+ Partials 10 0 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
services/web/server/src/simcore_service_webserver/catalog/_models.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/catalog/_models.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/catalog/_models.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
698d069
to
6028dda
Compare
Quality Gate passedIssues Measures |
What do these changes do?
During manual testing on the master deployment, specifically with PR #6169, we identified that the caching mechanism for the services listing is failing due to issues with async concurrency. This problem causes the entire service call to fail.
Changes in This PR
cachetools
has been replaced with an asynchronous caching solution usingaiocache
to better handle concurrent calls.asyncio.thread
, simplifying the implementation.cachetools
dependency has been removed from the project.Related issue/s
How to test
This issue can only be replicated using the config in master
Dev-ops checklist