Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [Frontend] Annotation creation enhancements #6164

Merged
merged 26 commits into from
Aug 15, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 9, 2024

What do these changes do?

Enhancements requested by @newton1985.

  • Save me one click when creating a text annotation from right click on the workbench, the position is already given.
  • Keep the last changed color for the next rectangle or text annotation
  • When creating a text annotation, expose all attribute options in the pop up window, not only the label
  • Make the delete annotation button more visible

AnnotationsEnh

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Aug 13, 2024
@odeimaiz odeimaiz added this to the Eisbock milestone Aug 13, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Aug 13, 2024
@odeimaiz odeimaiz changed the title Enh: annotation creation [Frontend] Annotation creation enhancement Aug 13, 2024
@odeimaiz odeimaiz changed the title [Frontend] Annotation creation enhancement 🎨 [Frontend] Annotation creation enhancement Aug 13, 2024
@odeimaiz odeimaiz added the UI/UX label Aug 14, 2024
@odeimaiz odeimaiz marked this pull request as ready for review August 14, 2024 13:13
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Annotation creation enhancement 🎨 [Frontend] Annotation creation enhancements Aug 14, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) August 14, 2024 13:44
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: which endpoint is used for the annotations?

@odeimaiz
Copy link
Member Author

Q: which endpoint is used for the annotations?

patch on the project level, they are part of the ui object.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link

Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, it helps a lot indeed.

@jsaq007
Copy link
Contributor

jsaq007 commented Aug 15, 2024

@odeimaiz I noticed when clicking on an item the color always opens in the top right corner. Isn't it possible to open it where you clicked? From a user experience it would be much nicer. Just my 2c worth.

jsaq007

This comment was marked as outdated.

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general nice one. I have one issues which I find a little unintuitive from a user perspective. As mentioned in my comment when clicking in an item the editor always opens in the top right corner.

I would think it better, if possible the editor to open where you clicked or as close to the item you click on as possible.

@odeimaiz odeimaiz merged commit 2757343 into ITISFoundation:master Aug 15, 2024
55 checks passed
@odeimaiz
Copy link
Member Author

odeimaiz commented Aug 15, 2024

In general nice one. I have one issues which I find a little unintuitive from a user perspective. As mentioned in my comment when clicking in an item the editor always opens in the top right corner.

I would think it better, if possible the editor to open where you clicked or as close to the item you click on as possible.

@jsaq007 I thought it cleaner to keep it on the top-right, but I'll change its position to top-right of the bounding box of the annotation 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants