Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Adds folders_get to folders db layer #6153

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Aug 8, 2024

What do these changes do?

Allows to query the information about a single folder via folder_id and gid.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Aug 8, 2024
@GitHK GitHK added the a:database associated to postgres service and postgres-database package label Aug 8, 2024
@GitHK GitHK added this to the Tom Bombadil milestone Aug 8, 2024
@GitHK GitHK marked this pull request as ready for review August 8, 2024 09:53
@GitHK GitHK requested a review from matusdrobuliak66 as a code owner August 8, 2024 09:53
@GitHK GitHK requested a review from sanderegg August 8, 2024 09:54
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.1%. Comparing base (cafbf96) to head (b96df56).
Report is 426 commits behind head on master.

Files Patch % Lines
...ase/src/simcore_postgres_database/utils_folders.py 88.8% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6153      +/-   ##
=========================================
+ Coverage    84.5%   89.1%    +4.5%     
=========================================
  Files          10    1261    +1251     
  Lines         214   53335   +53121     
  Branches       25     705     +680     
=========================================
+ Hits          181   47540   +47359     
- Misses         23    5637    +5614     
- Partials       10     158     +148     
Flag Coverage Δ
integrationtests 64.9% <ø> (?)
unittests 86.8% <88.8%> (+2.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ase/src/simcore_postgres_database/utils_folders.py 91.3% <88.8%> (ø)

... and 1228 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed it, but probably would have been better to create 3 columns instead of a json one in the first place. anyway. cool!

@sanderegg sanderegg modified the milestones: Tom Bombadil, Eisbock Aug 13, 2024
Copy link

@matusdrobuliak66 matusdrobuliak66 merged commit 5dfb050 into ITISFoundation:master Aug 13, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:database associated to postgres service and postgres-database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants