-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [Frontend] Connect folders to backend #6151
✨ [Frontend] Connect folders to backend #6151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! :) Did you also take the search bar into consideration? Does it behave reasonably?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🤩 I didn't have time yet to play with folders on master, but I am happy to do so if useful at this stage.
I like a lot the messages saying clearly that doing x is not supported yet, in my opinion we can potentially release it already like that (if all the rest works properly).
That's the only thing it's not yet connected to the backend: filter also folders by text and sort also the folders. |
Not there yet. The frontend doesn't always know if a study is part of a folder or not, and the backend will simply move it without checking it. We need both, the backend and frontend, to be aware of the constraints, and behave accordingly. Also, when deleting a folder, we need to warn the users of what it's being deleted, potentially listing all the studies that will be deleted... Without solving these two issues, I wouldn't move it beyond master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what a day!! nice!
Quality Gate passedIssues Measures |
What do these changes do?
This PR gets rid of the dummy frontend data and connects the folders functionality to the backend.
Still only available in master, until the sharing and other functionalities are implemented. Also, the "Move to folder" folders tree needs some love.
Users can:
Related issue/s
related to ITISFoundation/osparc-issues#716
How to test
Dev-ops checklist