Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Frontend] Connect folders to backend #6151

Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 8, 2024

What do these changes do?

This PR gets rid of the dummy frontend data and connects the folders functionality to the backend.

Still only available in master, until the sharing and other functionalities are implemented. Also, the "Move to folder" folders tree needs some love.

Users can:

  • Create folders and subfolders
  • List folders, subfolders and studies in there
  • Update the name and description
  • Delete folders (not sure what the backend does what it's content)
  • Move studies to folders

Folders

Related issue/s

related to ITISFoundation/osparc-issues#716

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Aug 8, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Aug 8, 2024
@odeimaiz odeimaiz added this to the Tom Bombadil milestone Aug 8, 2024
@odeimaiz odeimaiz marked this pull request as ready for review August 15, 2024 10:50
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :) Did you also take the search bar into consideration? Does it behave reasonably?

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🤩 I didn't have time yet to play with folders on master, but I am happy to do so if useful at this stage.

I like a lot the messages saying clearly that doing x is not supported yet, in my opinion we can potentially release it already like that (if all the rest works properly).

@odeimaiz
Copy link
Member Author

Nice! :) Did you also take the search bar into consideration? Does it behave reasonably?

That's the only thing it's not yet connected to the backend: filter also folders by text and sort also the folders.

@odeimaiz
Copy link
Member Author

Looks good! 🤩 I didn't have time yet to play with folders on master, but I am happy to do so if useful at this stage.

I like a lot the messages saying clearly that doing x is not supported yet, in my opinion we can potentially release it already like that (if all the rest works properly).

Not there yet. The frontend doesn't always know if a study is part of a folder or not, and the backend will simply move it without checking it. We need both, the backend and frontend, to be aware of the constraints, and behave accordingly.

Also, when deleting a folder, we need to warn the users of what it's being deleted, potentially listing all the studies that will be deleted...

Without solving these two issues, I wouldn't move it beyond master.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what a day!! nice!

Copy link

@odeimaiz odeimaiz merged commit 78a2e27 into ITISFoundation:master Aug 15, 2024
51 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 21, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants