Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Maintenance: mypy dynamic-sidecar #6126

Merged
merged 17 commits into from
Aug 19, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Aug 1, 2024

What do these changes do?

  • ♻️ removed duplicate models form sicmore-sdk and dask-task-models-library

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Aug 1, 2024
@GitHK GitHK added a:dynamic-sidecar dynamic-sidecar service t:maintenance Some planned maintenance work labels Aug 1, 2024
@GitHK GitHK added this to the Tom Bombadil milestone Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.8%. Comparing base (cafbf96) to head (3feed1b).
Report is 443 commits behind head on master.

Files Patch % Lines
...mcore_service_dynamic_sidecar/modules/nodeports.py 77.7% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6126      +/-   ##
=========================================
+ Coverage    84.5%   87.8%    +3.2%     
=========================================
  Files          10    1151    +1141     
  Lines         214   50428   +50214     
  Branches       25     790     +765     
=========================================
+ Hits          181   44306   +44125     
- Misses         23    5950    +5927     
- Partials       10     172     +162     
Flag Coverage Δ
integrationtests 64.8% <68.0%> (?)
unittests 85.3% <97.5%> (+0.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...src/dask_task_models_library/container_tasks/io.py 100.0% <100.0%> (ø)
...library/src/servicelib/long_running_tasks/_task.py 95.3% <100.0%> (ø)
...-sdk/src/simcore_sdk/node_ports_v2/nodeports_v2.py 93.3% <100.0%> (ø)
.../simcore-sdk/src/simcore_sdk/node_ports_v2/port.py 79.8% <100.0%> (ø)
...sdk/src/simcore_sdk/node_ports_v2/ports_mapping.py 100.0% <100.0%> (ø)
...r-v2/src/simcore_service_director_v2/utils/dask.py 89.8% <100.0%> (ø)
...mcore_service_dynamic_sidecar/api/_dependencies.py 100.0% <100.0%> (ø)
.../simcore_service_dynamic_sidecar/api/containers.py 98.1% <ø> (ø)
...namic_sidecar/api/containers_long_running_tasks.py 100.0% <100.0%> (ø)
...mcore_service_dynamic_sidecar/core/docker_utils.py 98.5% <100.0%> (ø)
... and 15 more

... and 1136 files with indirect coverage changes

@GitHK GitHK force-pushed the pr-osparc-mypy-dy-sidecar branch from 374c543 to e1c869c Compare August 1, 2024 11:01
@GitHK GitHK marked this pull request as ready for review August 1, 2024 13:56
@GitHK GitHK requested a review from matusdrobuliak66 August 1, 2024 13:56
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@GitHK GitHK enabled auto-merge (squash) August 8, 2024 06:45
@GitHK GitHK disabled auto-merge August 8, 2024 06:59
@GitHK GitHK enabled auto-merge (squash) August 8, 2024 06:59
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. Please check my comment on the CI

Copy link

@GitHK GitHK merged commit 68f1951 into ITISFoundation:master Aug 19, 2024
57 checks passed
@GitHK GitHK deleted the pr-osparc-mypy-dy-sidecar branch August 19, 2024 07:25
giancarloromeo pushed a commit to giancarloromeo/osparc-simcore that referenced this pull request Aug 19, 2024
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 21, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-sidecar dynamic-sidecar service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants