✨ [Frontend] Plus buttons escalate to latest compatible #6106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
requested review from
GitHK,
elisabettai,
pcrespov,
mguidon,
sanderegg and
matusdrobuliak66
pcrespov
approved these changes
Jul 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6106 +/- ##
=========================================
+ Coverage 84.5% 87.5% +3.0%
=========================================
Files 10 1137 +1127
Lines 214 49650 +49436
Branches 25 748 +723
=========================================
+ Hits 181 43485 +43304
- Misses 23 6005 +5982
- Partials 10 160 +150
Flags with carried forward coverage won't be shown. Click here to find out more.
|
odeimaiz
changed the title
GitHK
approved these changes
Jul 25, 2024
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/catalog/services.py
Show resolved
Hide resolved
matusdrobuliak66
approved these changes
Jul 25, 2024
elisabettai
approved these changes
Jul 25, 2024
jsaq007
approved these changes
Jul 29, 2024
services/static-webserver/client/source/class/osparc/share/PublishTemplate.js
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Regardless what service key hardcoded in the new_studies.json file, the plus button will point to the latest compatible service.
dev/services:Related issue/s
related to ITISFoundation/osparc-issues#1404
closes #5710
How to test
Dev-ops checklist