Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [Frontend] Make version display more prominent #6096

Merged
merged 27 commits into from
Jul 24, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 23, 2024

What do these changes do?

  • In the version selector, only the versionDisplay is visible
  • In the Service Large card, version will be either versionDisplay or version. For testers, the integration version will show the version.

Bonus:

  • Version selector as wide as the widest list item
  • Fix min Visible Inputs, metadata key changed
  • Cache service resources

VersionDisplay

Related issue/s

related to ITISFoundation/osparc-issues#1404

How to test

Dev-ops checklist

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Jul 23, 2024
@odeimaiz odeimaiz self-assigned this Jul 23, 2024
@odeimaiz odeimaiz changed the title Fix/version selector 🎨 [Frontend] Make version display more prominent Jul 23, 2024
@odeimaiz odeimaiz marked this pull request as ready for review July 23, 2024 19:41
@odeimaiz odeimaiz requested review from jsaq007 and ignapas as code owners July 23, 2024 19:41
@odeimaiz odeimaiz added this to the Tom Bombadil milestone Jul 23, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) July 23, 2024 19:52
@elisabettai
Copy link
Collaborator

elisabettai commented Jul 24, 2024

Thanks! Some questions (I may be out of date on how this has evolved in the past 2 weeks, so happy to have a look together in person).

  1. From a regular user point of view: what happens to the version selector if a "version display" in not specified? How can they choose an older version of a service?
  2. Similarly to 1, what will the service selector show when they open the service catalog in the workbench?
    image

@odeimaiz
Copy link
Member Author

Thanks! Some questions (I may be out of date on how this has evolved in the past 2 weeks, so happy to have a look together in person).

  1. From a regular user point of view: what happens to the version selector if a "version display" in not specified? How can they choose an older version of a service?
  2. Similarly to 1, what will the service selector show when they open the service catalog in the workbench?
    image

From this PR on, where we show the version number, if there is a displayVersion available, this is what it will be shown.

@elisabettai
Copy link
Collaborator

Thanks! Some questions (I may be out of date on how this has evolved in the past 2 weeks, so happy to have a look together in person).

  1. From a regular user point of view: what happens to the version selector if a "version display" in not specified? How can they choose an older version of a service?
  2. Similarly to 1, what will the service selector show when they open the service catalog in the workbench?
    image

From this PR on, where we show the version number, if there is a displayVersion available, this is what it will be shown.

Ok, thanks! So for old-school services (without versionDisplay), everything will behave as before if I understand it well.

@odeimaiz
Copy link
Member Author

Thanks! Some questions (I may be out of date on how this has evolved in the past 2 weeks, so happy to have a look together in person).

  1. From a regular user point of view: what happens to the version selector if a "version display" in not specified? How can they choose an older version of a service?
  2. Similarly to 1, what will the service selector show when they open the service catalog in the workbench?
    image

From this PR on, where we show the version number, if there is a displayVersion available, this is what it will be shown.

Ok, thanks! So for old-school services (without versionDisplay), everything will behave as before if I understand it well.

correct

Copy link

@odeimaiz odeimaiz merged commit b13510a into ITISFoundation:master Jul 24, 2024
51 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants