Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Allow project node patch of service key #6085

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Jul 19, 2024

What do these changes do?

  • 🎨 Allow project node patch of service key

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Jul 19, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review July 19, 2024 12:55
@matusdrobuliak66 matusdrobuliak66 added this to the Tom Bombadil milestone Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.6%. Comparing base (cafbf96) to head (0e7797f).
Report is 365 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6085      +/-   ##
=========================================
+ Coverage    84.5%   88.6%    +4.0%     
=========================================
  Files          10    1178    +1168     
  Lines         214   51594   +51380     
  Branches       25     560     +535     
=========================================
+ Hits          181   45730   +45549     
- Misses         23    5739    +5716     
- Partials       10     125     +115     
Flag Coverage Δ
integrationtests 63.5% <25.0%> (?)
unittests 86.5% <100.0%> (+1.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ls_library/api_schemas_webserver/projects_nodes.py 96.9% <100.0%> (ø)
...core_service_webserver/projects/_nodes_handlers.py 91.1% <100.0%> (ø)
...erver/src/simcore_service_webserver/projects/db.py 97.3% <100.0%> (ø)
...simcore_service_webserver/projects/projects_api.py 78.5% <100.0%> (ø)

... and 1167 files with indirect coverage changes

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) July 23, 2024 10:28
@matusdrobuliak66 matusdrobuliak66 merged commit f562f83 into ITISFoundation:master Jul 23, 2024
57 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants