Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Frontend] Use new /dev/services endpoint and its new metadata #6016

Merged
merged 113 commits into from
Jul 23, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 1, 2024

What do these changes do?

New /dev/services:

  • Refactor the frontend to be compatible with the new services/-/latest end point and lazy load the required service metadata
  • New Services Store implemented in the frontend. Latest services will be loaded at startup and other required services will be fetched on demand.
  • Support new service access-right keys: write_access -> write, execute_access -> execute
  • Support new boot-options -> `bootOptions`` key

New metadata:

  • Support cross-service-key updates
  • Show Release Date if any
  • Show Version Display in version selectors and info card

Related issue/s

related to ITISFoundation/osparc-issues#1404

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Jul 1, 2024
@odeimaiz odeimaiz added this to the South Island Iced Tea milestone Jul 1, 2024
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Jul 1, 2024
@odeimaiz odeimaiz changed the title ✨ [Frontend] /dev/services ✨ [Frontend] Use new /dev/services endpoint and its new metadata Jul 21, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

Q1: Is the old GUI still active (i.e. keep old and new versions) or after this PR, the new is taking over. If the latter, we must point to non-dev entrypoints before we merge this to master!

Q2: How does this compare in speed wrt to the old version?

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! looking forward to seeing it in action

@odeimaiz
Copy link
Member Author

Very nice.

Q1: Is the old GUI still active (i.e. keep old and new versions) or after this PR, the new is taking over. If the latter, we must point to non-dev entrypoints before we merge this to master!

Q2: How does this compare in speed wrt to the old version?

@pcrespov

A1: The latter. So, yes, I need your change in #6084 also to make the tests here green, thanks.

A2: Tricky question. First of all, I didn't have the feeling the waiting time for my user was long.
Before, we were fetching all the services metadata at once and that endpoint wouldn't be used again.
Now, we fetch only the latest version metadata and the whole history of the service (which already brings new features) at start up, and later, only when necessary, other version's metadata. This follow up calls are not noticeable for the user.
So, I believe, it's fare to make the comparison between the old /services and the new /dev/services/-/latest calls. Since @mguidon, has access to many versions in many services, therefor long waiting times, he might be the best user to tell us how much this new endpoint improves the UX.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very big one. looking forward for the changes.

@odeimaiz odeimaiz enabled auto-merge (squash) July 22, 2024 13:49
Copy link

@odeimaiz odeimaiz merged commit 5a2e51d into ITISFoundation:master Jul 23, 2024
51 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants