-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Splits models_library.services #5921
♻️ Splits models_library.services #5921
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5921 +/- ##
=========================================
+ Coverage 84.5% 88.2% +3.6%
=========================================
Files 10 1165 +1155
Lines 214 50810 +50596
Branches 25 573 +548
=========================================
+ Hits 181 44827 +44646
- Misses 23 5860 +5837
- Partials 10 123 +113
Flags with carried forward coverage won't be shown. Click here to find out more.
|
218e2b5
to
ad032a6
Compare
b8d5813
to
128befa
Compare
Quality Gate passedIssues Measures |
128befa
to
40cf3ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good, you have a service_runtime.py that is empty
packages/models-library/src/models_library/services_authoring.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/services_constants.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the effort!
What do these changes do?
models_library.services
into more manageable sub-modules. This is the rationalemodels_library.services
acts as the main module APImodels_library.services_*
act as submodules. Can be either imported directly and/or some functionality is exposed to the main module APImake doc-uml
on any package to produce UML diagrams. Based in pyreverse which comes with pylint.Related issue/s
models_library.services
#3486How to test
doc-uml
to trace code inhertance/composition relations between modelscd packages/models-library
(or any other package/service)make -n doc-uml
(export DOC_UML_PATH_SUFFIX="services*"; export DOC_UML_CLASS=models_library.api_schemas_catalog.services.ServiceGet; make doc-uml)
Dev-ops checklist
None