Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️🎨 ooil config init to create first.osparc config layout #5913

Merged
merged 15 commits into from
Jun 6, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 4, 2024

What do these changes do?

ooil CLI can now create an .osparc config folder with ooil config init by running the cookiecutter-osparc-service). In addition we do some refactoring of the oldest part of the tool before the coming upgrades

Highlights

ooil config init

or

ooil config init --template=gh:pcrespov/cookiecutter-osparc-service --checkout=is1404/new-version_display
  • ♻️ CLI logic
    • Moves to service_integration.cli
    • Upgrades types Annotations
    • Improved doc

Related issue/s

How to test

Manual testing using ooil image

cd packages/service-integration
make build
script/ooil.bash --help

image

Dev-ops checklist

None

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 83.13253% with 14 lines in your changes missing coverage. Please review.

Project coverage is 87.6%. Comparing base (cafbf96) to head (b168040).
Report is 258 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5913      +/-   ##
=========================================
+ Coverage    84.5%   87.6%    +3.0%     
=========================================
  Files          10    1013    +1003     
  Lines         214   45180   +44966     
  Branches       25     303     +278     
=========================================
+ Hits          181   39609   +39428     
- Misses         23    5502    +5479     
- Partials       10      69      +59     
Flag Coverage Δ
integrationtests 63.5% <ø> (?)
unittests 85.3% <83.1%> (+0.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tegration/src/service_integration/cli/_metadata.py 100.0% <100.0%> (ø)
...ration/src/service_integration/cli/_run_creator.py 80.6% <100.0%> (ø)
...e-integration/src/service_integration/cli/_test.py 57.1% <100.0%> (ø)
...vice-integration/src/service_integration/errors.py 100.0% <100.0%> (ø)
...tegration/src/service_integration/osparc_config.py 92.0% <100.0%> (ø)
...ation/src/service_integration/cli/_compose_spec.py 75.5% <87.5%> (ø)
...ntegration/src/service_integration/cli/__init__.py 85.1% <85.1%> (ø)
...integration/src/service_integration/cli/_config.py 79.3% <66.6%> (ø)

... and 1014 files with indirect coverage changes

@pcrespov pcrespov self-assigned this Jun 4, 2024
@pcrespov pcrespov added the a:ooil integration-library or ooil label Jun 5, 2024
@pcrespov pcrespov changed the title WIP: 🎨 enhaces on OOIL 🎨 ooil config init creates an initial .osparc config layout Jun 5, 2024
@pcrespov pcrespov added this to the Leeroy Jenkins milestone Jun 6, 2024
@pcrespov pcrespov changed the title 🎨 ooil config init creates an initial .osparc config layout ♻️🎨 ooil config init to create first.osparc config layout Jun 6, 2024
@pcrespov pcrespov marked this pull request as ready for review June 6, 2024 08:58
@pcrespov pcrespov requested review from sanderegg and GitHK as code owners June 6, 2024 08:58
@pcrespov pcrespov enabled auto-merge (squash) June 6, 2024 08:59
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

@pcrespov pcrespov merged commit 74d4870 into ITISFoundation:master Jun 6, 2024
57 checks passed
@pcrespov pcrespov deleted the is1404/enh-ooil branch June 6, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:ooil integration-library or ooil
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants