-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨♻️ New version_display
and release_date
fields for service metadata
#5902
✨♻️ New version_display
and release_date
fields for service metadata
#5902
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5902 +/- ##
=========================================
+ Coverage 84.5% 88.1% +3.5%
=========================================
Files 10 1110 +1100
Lines 214 48266 +48052
Branches 25 563 +538
=========================================
+ Hits 181 42556 +42375
- Misses 23 5587 +5564
- Partials 10 123 +113
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b02d463
to
5e65852
Compare
version_display
and release_date
fields for service metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. @GitHK Are you going to release a new version for the service-integration
image? Last time you told me that I shoud not use master-github-latest
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks a lot!
I guess at some point it might be interesting to add also a field for the changelog, not necessary for the current tasks obviously.
And I assume different services can NOT have the same version
but can potentially have the same version_display
.
@elisabettai more metadata will be added. This is just an initial change to review and update the entire workflow (from creation, parsing, integration, apis, etc). Once is done we will be able to add more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thank you. please have a look at the release date vs datetime consideration.
packages/service-integration/src/service_integration/osparc_config.py
Outdated
Show resolved
Hide resolved
services/api-server/tests/unit/api_solvers/test_api_routers_solvers_jobs.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of observations form me
packages/service-integration/src/service_integration/commands/run_creator.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Thanks a lot!
Quality Gate passedIssues Measures |
What do these changes do?
ServiceDockerData
, namelyversion_display
andrelease_date
(backwards compatible)ooil
can produce labels for the new fields in mimage 'service-integration version: 1.0.3 → 1.0.4'models_library.services
Next PR will review and update the entire logic from the registry to the webserver API.
Related issue/s
How to test
should produce a
docker-compose.yml
Dev-ops checklist