-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ dynamic-scheduler
pushes service state to the frontend (⚠️ devops)
#5892
✨ dynamic-scheduler
pushes service state to the frontend (⚠️ devops)
#5892
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5892 +/- ##
=========================================
+ Coverage 84.5% 88.2% +3.6%
=========================================
Files 10 1520 +1510
Lines 214 62612 +62398
Branches 25 2023 +1998
=========================================
+ Hits 181 55272 +55091
- Misses 23 7028 +7005
- Partials 10 312 +302
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…duler-polls-for-service-status
…duler-polls-for-service-status
…duler-polls-for-service-status
…duler-polls-for-service-status
…duler-polls-for-service-status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good. a few comments left. we can discuss tomorrow if you want.
packages/service-library/src/servicelib/deferred_tasks/_redis_task_tracker.py
Show resolved
Hide resolved
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/api/rpc/_services.py
Show resolved
Hide resolved
…duler-polls-for-service-status
…duler-polls-for-service-status
…duler-polls-for-service-status
…hub.com:GitHK/osparc-simcore-forked into pr-osparc-dy-scheduler-polls-for-service-status
Quality Gate passedIssues Measures |
ITISFoundation#5892) Co-authored-by: Andrei Neagu <[email protected]>
ITISFoundation#5892) Co-authored-by: Andrei Neagu <[email protected]>
Merger the following after releasing to:
What do these changes do?
Service status is monitored by
dynamic-scheduler
. Whenever the status changes it is pushed via websocket to the fronted as a message calledserviceStatus
.director-v2
's service tracking and does not interfere!Other changes:
get_dict_from_status
shared between services is used to serialise the status to the FERedisClientSDK
now supports decode_response, which disables automatic encoding and decoding of bytes to strings, thus supporting raw bytes to be stored and recovered.TODOs:
Related issue/s
RedisClientsManager
andRedisClientSDK
#5888How to test
Dev-ops checklist