Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Only allow to search *owned* files in storage search endpoint #5772

Merged
merged 13 commits into from
May 3, 2024
Merged

🐛 Only allow to search *owned* files in storage search endpoint #5772

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1a4a287
only search write access files in api-server
bisgaard-itis May 2, 2024
18d4309
change all file searches to write access searches
bisgaard-itis May 2, 2024
c965287
remove search fcn for read-only files
bisgaard-itis May 3, 2024
c932ed2
update storage openapi specs
bisgaard-itis May 3, 2024
af0927e
use new storage endpoint in api-server
bisgaard-itis May 3, 2024
03cf3ce
minor change
bisgaard-itis May 3, 2024
35f8301
fix api-server unit tests
bisgaard-itis May 3, 2024
797c957
@pcrespov @wvangeit POST /simcore-s3/files/metadata:search?kind=owned
bisgaard-itis May 3, 2024
2290361
correction in api-server
bisgaard-itis May 3, 2024
22cda18
add tests for different kinds
bisgaard-itis May 3, 2024
e064280
fix tests in api-server
bisgaard-itis May 3, 2024
25bcbcb
merge master into 5771-only-search-write-files-in-api-server
bisgaard-itis May 3, 2024
e00d85c
fix search in list_files
bisgaard-itis May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions services/api-server/src/simcore_service_api_server/api/routes/files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ async def get_file(
file_id=file_id,
storage_client=storage_client,
user_id=user_id,
access_right="read",
access_right="write",
bisgaard-itis marked this conversation as resolved.
Show resolved Hide resolved
)


Expand All @@ -311,7 +311,7 @@ async def search_files_page(
user_id=user_id,
file_id=file_id,
sha256_checksum=sha256_checksum,
access_right="read",
access_right="write",
)
if page_params.offset > len(stored_files):
_logger.debug("File with sha256_checksum=%d not found.", sha256_checksum)
Expand Down
2 changes: 1 addition & 1 deletion services/api-server/src/simcore_service_api_server/api/routes/solvers_jobs_getters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ async def get_job_outputs(
user_id=user_id,
file_id=file_id,
sha256_checksum=None,
access_right="read",
access_right="write",
)
if found:
assert len(found) == 1 # nosec
Expand Down
Loading