Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› πŸ—ƒοΈ Add index to checksum #5748

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Apr 26, 2024

What do these changes do?

  • As pointed out by @sanderegg we should probably also index checksum
  • πŸ—ƒοΈ migration

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Apr 26, 2024
@bisgaard-itis bisgaard-itis added bug buggy, it does not work as expected a:storage issue related to storage service a:database associated to postgres service and postgres-database package labels Apr 26, 2024
@bisgaard-itis bisgaard-itis added this to the Enchanted Odyssey milestone Apr 26, 2024
@bisgaard-itis bisgaard-itis changed the title Add index to checksum πŸ› Add index to checksum Apr 26, 2024
@bisgaard-itis bisgaard-itis marked this pull request as ready for review April 26, 2024 11:50
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ Based on which query?

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 77.9%. Comparing base (cafbf96) to head (e53869e).
Report is 156 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5748      +/-   ##
=========================================
- Coverage    84.5%   77.9%    -6.7%     
=========================================
  Files          10     558     +548     
  Lines         214   28076   +27862     
  Branches       25     205     +180     
=========================================
+ Hits          181   21876   +21695     
- Misses         23    6148    +6125     
- Partials       10      52      +42     
Flag Coverage Ξ”
integrationtests 65.2% <ΓΈ> (?)
unittests 79.8% <ΓΈ> (-4.8%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 568 files with indirect coverage changes

@bisgaard-itis
Copy link
Contributor Author

πŸ‘ Based on which query?

Same as we watched yesterday. You probably already suggested to perform this change yesterday. But for some reason I didn't do it.

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) April 26, 2024 13:07
@bisgaard-itis bisgaard-itis merged commit b4bab34 into ITISFoundation:master Apr 26, 2024
56 checks passed
@bisgaard-itis bisgaard-itis deleted the index-checksum branch April 26, 2024 13:18
@matusdrobuliak66 matusdrobuliak66 changed the title πŸ› Add index to checksum πŸ› πŸ—ƒοΈ Add index to checksum Apr 29, 2024
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 29, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:database associated to postgres service and postgres-database package a:storage issue related to storage service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants