Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Frontend: API Keys enhancements #5731

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 25, 2024

What do these changes do?

  • Support expiration date when creating keys
  • Partially hide key and secret

APIKeys

Related issue/s

closes #4541
closes #5658

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Apr 25, 2024
@odeimaiz odeimaiz changed the title WIP 🎨 Frontend: Enhancements API Keys WIP 🎨 Frontend: API Keys enhancements Apr 25, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@odeimaiz odeimaiz marked this pull request as ready for review April 25, 2024 08:01
@odeimaiz odeimaiz changed the title WIP 🎨 Frontend: API Keys enhancements 🎨 Frontend: API Keys enhancements Apr 25, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) April 25, 2024 08:05
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.9%. Comparing base (cafbf96) to head (82dff9d).
Report is 144 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5731      +/-   ##
=========================================
- Coverage    84.5%   63.9%   -20.6%     
=========================================
  Files          10     558     +548     
  Lines         214   28038   +27824     
  Branches       25     204     +179     
=========================================
+ Hits          181   17941   +17760     
- Misses         23   10045   +10022     
- Partials       10      52      +42     
Flag Coverage Δ
integrationtests 63.9% <ø> (?)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 568 files with indirect coverage changes

Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great enhancement, thanks

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! thanks

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature labels Apr 25, 2024
@odeimaiz odeimaiz merged commit fb106a7 into ITISFoundation:master Apr 25, 2024
56 checks passed
@pcrespov pcrespov added this to the Enchanted Odyssey milestone Apr 25, 2024
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 26, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: API Key window shall provides partial view of secrets UI: api keys have now expiration date
6 participants