Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Add prometheus metrics for logstreaming #5594

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Apr 2, 2024

What do these changes do?

  • Introduce prometheus metrics which record the number of log messages currently held by the LogDistributor inside the api server. After setting up a Grafana dashboard for visualizing these we will have a view similar to the RabbitMQ GUI for the logs held in memory by the API-server. This should help debug the issues we have encountered with the logstreaming.

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Apr 2, 2024
@bisgaard-itis bisgaard-itis added the a:apiserver api-server service label Apr 2, 2024
@bisgaard-itis bisgaard-itis added this to the Enchanted Odyssey milestone Apr 2, 2024
@bisgaard-itis bisgaard-itis marked this pull request as ready for review April 2, 2024 12:14
@bisgaard-itis bisgaard-itis requested a review from pcrespov as a code owner April 2, 2024 12:14
….com:bisgaard-itis/osparc-simcore into 5591-add-prometheus-metrics-for-logstreaming
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some questions :--) please ping me if they are answered thanks a lot

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good please use tenacity in place of the wheel loop

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 96.82540% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 65.8%. Comparing base (cafbf96) to head (a30c3a3).
Report is 76 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5594      +/-   ##
=========================================
- Coverage    84.5%   65.8%   -18.7%     
=========================================
  Files          10     627     +617     
  Lines         214   30619   +30405     
  Branches       25     204     +179     
=========================================
+ Hits          181   20174   +19993     
- Misses         23   10393   +10370     
- Partials       10      52      +42     
Flag Coverage Δ
integrationtests 64.0% <ø> (?)
unittests 84.9% <96.8%> (+0.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ore_service_api_server/api/errors/custom_errors.py 76.1% <100.0%> (ø)
...src/simcore_service_api_server/core/application.py 98.7% <100.0%> (ø)
...er/src/simcore_service_api_server/core/settings.py 90.2% <100.0%> (ø)
...mcore_service_api_server/services/log_streaming.py 91.1% <100.0%> (ø)
...re_service_api_server/api/dependencies/rabbitmq.py 88.0% <90.9%> (ø)
...ice_api_server/core/_prometheus_instrumentation.py 97.2% <97.2%> (ø)

... and 631 files with indirect coverage changes

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bisgaard-itis bisgaard-itis requested review from pcrespov and GitHK April 2, 2024 16:25
@bisgaard-itis bisgaard-itis enabled auto-merge (squash) April 3, 2024 06:30
Copy link

sonarqubecloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bisgaard-itis bisgaard-itis merged commit 5e33f7f into ITISFoundation:master Apr 3, 2024
56 checks passed
@bisgaard-itis bisgaard-itis deleted the 5591-add-prometheus-metrics-for-logstreaming branch April 3, 2024 08:02
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 26, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prometheus metrics to api server for logstreaming endpoint
6 participants