-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Add prometheus metrics for logstreaming #5594
🎨 Add prometheus metrics for logstreaming #5594
Conversation
….com:bisgaard-itis/osparc-simcore into 5591-add-prometheus-metrics-for-logstreaming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some questions :--) please ping me if they are answered thanks a lot
services/api-server/src/simcore_service_api_server/core/_prometheus_instrumentation.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good please use tenacity in place of the wheel loop
services/api-server/src/simcore_service_api_server/api/dependencies/rabbitmq.py
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5594 +/- ##
=========================================
- Coverage 84.5% 65.8% -18.7%
=========================================
Files 10 627 +617
Lines 214 30619 +30405
Branches 25 204 +179
=========================================
+ Hits 181 20174 +19993
- Misses 23 10393 +10370
- Partials 10 52 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! :)
services/api-server/src/simcore_service_api_server/services/log_streaming.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/dependencies/rabbitmq.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/core/_prometheus_instrumentation.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/core/_prometheus_instrumentation.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/core/_prometheus_instrumentation.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/services/log_streaming.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/core/_prometheus_instrumentation.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/core/_prometheus_instrumentation.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/core/_prometheus_instrumentation.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
services/api-server/src/simcore_service_api_server/core/_prometheus_instrumentation.py
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
What do these changes do?
LogDistributor
inside the api server. After setting up a Grafana dashboard for visualizing these we will have a view similar to the RabbitMQ GUI for the logs held in memory by the API-server. This should help debug the issues we have encountered with the logstreaming.Related issue/s
How to test
Dev-ops checklist