Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 adding missing env var to docker-compose.yaml #5011

Merged
merged 6 commits into from
Nov 14, 2023
Merged

🐛 adding missing env var to docker-compose.yaml #5011

merged 6 commits into from
Nov 14, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 10, 2023 •
edited
Loading

What do these changes do?

Adds missing env var as requested in #4986 (comment)

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@GitHK GitHK self-assigned this Nov 10, 2023
@GitHK GitHK added the a:director-v2 issue related with the director-v2 service label Nov 10, 2023
@GitHK GitHK added this to the 7peaks milestone Nov 10, 2023
@GitHK GitHK marked this pull request as ready for review November 10, 2023 13:38
@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023 •
edited
Loading

Codecov Report

Merging #5011 (2e5e397) into master (9cabec0) will increase coverage by 1.3%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5011     +/-   ##
========================================
+ Coverage    85.9%   87.2%   +1.3%     
========================================
  Files        1245    1245             
  Lines       51257   51257             
  Branches     1085    1085             
========================================
+ Hits        44057   44735    +678     
+ Misses       6968    6283    -685     
- Partials      232     239      +7
Flag Coverage Δ
integrationtests 65.1% <ø> (+6.6%) ⬆️
unittests 85.0% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 39 files with indirect coverage changes

YuryHrytsuk
YuryHrytsuk requested changes Nov 10, 2023
View reviewed changes
services/docker-compose.yml Outdated Show resolved Hide resolved
@GitHK GitHK requested a review from YuryHrytsuk November 10, 2023 13:41
@GitHK GitHK requested a review from pcrespov as a code owner November 13, 2023 15:00
YuryHrytsuk
YuryHrytsuk approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

docs/env-vars.md Show resolved Hide resolved
sanderegg
sanderegg reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure self-consistent is what you wanna use here ;)
self-contained: https://www.google.com/search?q=self+contained&rlz=1C1CHBD_enCH898CH898&oq=self+contained&gs_lcrp=EgZjaHJvbWUqCwgAEEUYJxg7GIoFMgsIABBFGCcYOxiKBTIMCAEQABgUGIcCGIAEMgcIAhAAGIAEMgcIAxAAGIAEMgcIBBAAGIAEMgcIBRAAGIAEMgcIBhAAGIAEMgcIBxAAGIAEMgcICBAAGIAEMgcICRAAGIAE0gEIMTU5N2owajmoAgCwAgA&sourceid=chrome&ie=UTF-8
self-consistent: https://www.google.com/search?q=self+consistent&rlz=1C1CHBD_enCH898CH898&oq=self+consistent&gs_lcrp=EgZjaHJvbWUyBggAEEUYQDIGCAEQRRhA0gEIMjgzMmowajmoAgCwAgA&sourceid=chrome&ie=UTF-8

docs/env-vars.md Outdated Show resolved Hide resolved
@GitHK GitHK enabled auto-merge (squash) November 14, 2023 08:19
@GitHK GitHK requested a review from sanderegg November 14, 2023 08:19
@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 14, 2023

Code Climate has analyzed commit 2e5e397 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@GitHK GitHK merged commit 4d75a0c into ITISFoundation:master Nov 14, 2023
59 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 15, 2023
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov pcrespov approved these changes

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11 mrnicegyu11 is a code owner

Assignees

@GitHK GitHK

Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Milestone
7peaks
Development

Successfully merging this pull request may close these issues.
4 participants
@GitHK @pcrespov @sanderegg @YuryHrytsuk