-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨oSPARC API keys are created and removed if a service requires them #5004
✨oSPARC API keys are created and removed if a service requires them #5004
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5004 +/- ##
========================================
+ Coverage 87.2% 87.4% +0.1%
========================================
Files 1250 1047 -203
Lines 51237 46090 -5147
Branches 1107 540 -567
========================================
- Hits 44699 40297 -4402
+ Misses 6299 5672 -627
+ Partials 239 121 -118
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…-api-keyreplacement
…-api-keyreplacement
packages/models-library/src/models_library/api_schemas_api_server/api_keys.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_api_server/api_keys.py
Show resolved
Hide resolved
packages/service-library/src/servicelib/osparc_generic_resource.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/osparc_generic_resource.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/osparc_generic_resource.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/osparc_generic_resource.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/osparc_generic_resource.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/api_key_resource_manager.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/api_key_resource_manager.py
Outdated
Show resolved
Hide resolved
…HK/osparc-simcore-forked into pr-osparc-support-api-keyreplacement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i do not want to delay this more ... but I think this PR will have an unnecessary maintenance overhead :-(
services/director-v2/src/simcore_service_director_v2/modules/osparc_variables_substitutions.py
Show resolved
Hide resolved
...-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_events_utils.py
Outdated
Show resolved
Hide resolved
…-api-keyreplacement
…-api-keyreplacement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go for it and thanks for the changes and talk!
Code Climate has analyzed commit f8f6a4d and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
DISCLAIMER: This PR, being small, is more noisy than I would have preferred.
Makes sure that for every each run there are different oSPARC API keys for each service which requires them.
Changes per service:
packages
:BaseOsparcGenericResourceManager
. The user only needs tocreate
read
anddelete
and the resource lifecycle is simplified.ApiKeyInDB
moved fromapi-server
tomodels-library
director-v2
:director-v2
creates and removes api keys, if required, whenever a service is started and shut downresolve_and_substitute_lifespan_variables_in_specs
and now used when startingdynamic-services
webserver
:webserver
's web API specwebserver
to get an existing API keywebserver
Related issue/s
How to test
DevOps Checklist