Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ aio-pika: unblock constraint and fix test #4605

Merged
merged 6 commits into from
Aug 11, 2023

Conversation

sanderegg
Copy link
Member

Highlights on updated libraries (only updated libraries are included)

  • #packages before: 2
  • #packages after : 2
# name before after upgrade count packages
1 aio-pika 9.1.2 9.2.1 minor 1 service-library🧪
2 aiormq 6.7.6 6.7.7 1 service-library🧪

Legend:

  • ⬆️ base dependency (only services because packages are floating)

  • 🧪 test dependency

  • 🔧 tool dependency

  • fixed failing test and allow aio-pika to update again.

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added a:services-library issues on packages/service-libs t:maintenance Some planned maintenance work labels Aug 11, 2023
@sanderegg sanderegg added this to the Sundae milestone Aug 11, 2023
@sanderegg sanderegg self-assigned this Aug 11, 2023
@sanderegg sanderegg requested a review from pcrespov as a code owner August 11, 2023 08:09
@sanderegg sanderegg changed the title Aio pika/unblock version ⬆️ aio-pika: unblock constraint and fix test Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #4605 (231199c) into master (a801330) will decrease coverage by 3.3%.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4605      +/-   ##
=========================================
- Coverage    84.4%   81.1%    -3.3%     
=========================================
  Files        1047     695     -352     
  Lines       44466   29325   -15141     
  Branches     1014     533     -481     
=========================================
- Hits        37535   23802   -13733     
+ Misses       6712    5409    -1303     
+ Partials      219     114     -105     
Flag Coverage Δ
unittests 81.1% <100.0%> (-3.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ackages/service-library/src/servicelib/rabbitmq.py 94.1% <100.0%> (+<0.1%) ⬆️

... and 389 files with indirect coverage changes

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks the upgrade

@sanderegg sanderegg force-pushed the aio-pika/unblock-version branch from bdd740d to 231199c Compare August 11, 2023 08:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Aug 11, 2023

Code Climate has analyzed commit 231199c and detected 0 issues on this pull request.

View more on Code Climate.

@sanderegg sanderegg merged commit 6555d8d into ITISFoundation:master Aug 11, 2023
@sanderegg sanderegg deleted the aio-pika/unblock-version branch August 11, 2023 08:41
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:services-library issues on packages/service-libs t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking changes with aio-pika>9.1.2
3 participants