-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix templates publish/open with states as directories #4586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the _get_size function and the datetime format. not sure this will not trigger an issue.
Codecov Report
@@ Coverage Diff @@
## master #4586 +/- ##
========================================
- Coverage 76.2% 67.1% -9.2%
========================================
Files 562 484 -78
Lines 27975 25294 -2681
Branches 533 188 -345
========================================
- Hits 21332 16980 -4352
- Misses 6519 8267 +1748
+ Partials 124 47 -77
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…mcore-forked into pr-osparc-fix-copy-s3-s3
Code Climate has analyzed commit a0eb8ab and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice thanks. I am not sure I understand why you create test_simcore_s3_dsm.py while there is already a test_handlers_simcore_s3.py. But whatever, very cool! thanks!
What do these changes do?
Templates were broken since the states of the folders are treated as folders.
Related issue/s
M1-12 Maintenance and DevOps osparc-issues#675
allows master to be published 🚀 Release v1.58.0 #4574
How to test
DevOps Checklist