Adds dynamic-sidecar osparc service (🏗️actions required) #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHK
added
idea
Codecov Report
@@ Coverage Diff @@
## master #2271 +/- ##
========================================
+ Coverage 71.6% 71.8% +0.2%
========================================
Files 488 504 +16
Lines 19286 19702 +416
Branches 1897 1931 +34
========================================
+ Hits 13815 14164 +349
- Misses 5009 5067 +58
- Partials 462 471 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GitHK
changed the title
GitHK
changed the title
…ore-forked into adding-dynamic-sidecar
added 10 commits
April 14, 2021 10:04
added 6 commits
April 23, 2021 17:33
added 6 commits
April 26, 2021 08:23
sanderegg
reviewed
Apr 26, 2021
pcrespov
reviewed
Apr 26, 2021
| ) | ||
| except InvalidComposeSpec as e: | ||
| logger.warning("Error detected %s", traceback.format_exc()) | ||
| raise HTTPException(status.HTTP_500_INTERNAL_SERVER_ERROR, detail=str(e)) from e |
There was a problem hiding this comment.
I guess you missed this one...
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/containers.py
Outdated
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/containers.py
Outdated
Show resolved
Hide resolved
pcrespov
reviewed
Apr 26, 2021
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/containers.py
Outdated
Show resolved
Hide resolved
sanderegg
approved these changes
Apr 26, 2021
| """ Expects the docker-compose spec as raw-body utf-8 encoded text """ | ||
|
|
||
| # stores the compose spec after validation | ||
| body_as_text = (await request.body()).decode("utf-8") |
There was a problem hiding this comment.
ok, and the plan is to move to some pydantic model later on?
|
|
||
| # pending is another fake state use to share more information with the frontend | ||
| return { | ||
| "Status": container_state.get("Status", "pending"), |
There was a problem hiding this comment.
are you sure the docker engine does not return anything special when pulling/starting?
There was a problem hiding this comment.
Yes, I've checked when putting this comment. It's needed for the frontend because we are mapping from task to container statues which do not overlap completely
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/containers.py
Outdated
Show resolved
Hide resolved
pcrespov
approved these changes
Apr 26, 2021
| logger.warning( | ||
| "An unexpected Docker error occurred:\n%s", str(traceback.format_exc()) | ||
| ) | ||
| raise HTTPException( |
There was a problem hiding this comment.
Much better! But i still think we should somehow find a better code than 500 for this. As I said several times above, this is already the default behaviour of fastapi
GitHK
changed the title
GitHK
changed the title
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏗️ Maintenance
After this is merged need to mark the new unit-test for the dynamic sidecar as mandatory.
What do these changes do?
Splitting the new service from #1887 and renaming it to
dynamic-sidecar.This PR is required by #1887
service-sidecartodynamic-sidecarBonus:
make github-workflow-job job=JOB_NAMEopenapi.json
Related issue/s
ITISFoundation/osparc-issues#349
How to test
Checklist