Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e false positives #1428

Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 2, 2020

What do these changes do?

Instead of waiting a hardcoded amount of time for the service to be ready, a Node status listener was added. Now puppeteer waits until the service_state says running.

Related issue number

related to #1426

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #1428 into master will increase coverage by 4.96%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
+ Coverage   71.21%   76.18%   +4.96%     
==========================================
  Files         237      149      -88     
  Lines        9371     6329    -3042     
  Branches     1028      722     -306     
==========================================
- Hits         6674     4822    -1852     
+ Misses       2397     1279    -1118     
+ Partials      300      228      -72
Flag Coverage Δ
#integrationtests 59.09% <ø> (ø) ⬆️
#unittests 73.11% <ø> (+10.89%) ⬆️
Impacted Files Coverage Δ
.../simcore-sdk/src/simcore_sdk/node_data/__init__.py 0% <0%> (-100%) ⬇️
...core-sdk/src/simcore_sdk/node_data/data_manager.py 0% <0%> (-95.24%) ⬇️
...ore-sdk/src/simcore_sdk/node_ports/_schema_item.py 87.5% <0%> (-12.5%) ⬇️
...mcore-sdk/src/simcore_sdk/node_ports/exceptions.py 62.12% <0%> (-10.61%) ⬇️
...mcore-sdk/src/simcore_sdk/node_ports/_data_item.py 78.94% <0%> (-10.53%) ⬇️
...es/simcore-sdk/src/simcore_sdk/node_ports/_item.py 84.25% <0%> (-9.26%) ⬇️
...sdk/src/simcore_sdk/node_ports/_data_items_list.py 57.89% <0%> (-5.27%) ⬇️
...core-sdk/src/simcore_sdk/node_ports/_items_list.py 88.37% <0%> (-2.33%) ⬇️
...s/storage/src/simcore_service_storage/db_tokens.py
...orage/src/simcore_service_storage/config_schema.py
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45dfff6...aa8eec6. Read the comment docs.

@odeimaiz odeimaiz self-assigned this Apr 2, 2020
@odeimaiz odeimaiz changed the title WIP: Fix e2e false positives Fix e2e false positives Apr 2, 2020
@odeimaiz odeimaiz added this to the Dim Sum milestone Apr 2, 2020
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz merged commit a7fac9b into ITISFoundation:master Apr 3, 2020
@sanderegg sanderegg linked an issue Apr 6, 2020 that may be closed by this pull request
@odeimaiz odeimaiz deleted the feature/fix-e2e-false-positive branch August 18, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

platform stability
4 participants