-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix e2e false positives #1428
Fix e2e false positives #1428
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1428 +/- ##
==========================================
+ Coverage 71.21% 76.18% +4.96%
==========================================
Files 237 149 -88
Lines 9371 6329 -3042
Branches 1028 722 -306
==========================================
- Hits 6674 4822 -1852
+ Misses 2397 1279 -1118
+ Partials 300 228 -72
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What do these changes do?
Instead of waiting a hardcoded amount of time for the service to be ready, a Node status listener was added. Now puppeteer waits until the service_state says running.
Related issue number
related to #1426
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)