Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue when next_task_nodes is None #1411

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

sanderegg
Copy link
Member

What do these changes do?

  • fix issue when next_task_nodes is empty

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@sanderegg sanderegg added this to the Dim Sum milestone Mar 29, 2020
@sanderegg sanderegg self-assigned this Mar 29, 2020
@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #1411 into master will decrease coverage by 21.3%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1411      +/-   ##
=========================================
- Coverage    71.2%   49.9%   -21.3%     
=========================================
  Files         237     123     -114     
  Lines        9371    4398    -4973     
  Branches     1027     475     -552     
=========================================
- Hits         6673    2195    -4478     
+ Misses       2398    2107     -291     
+ Partials      300      96     -204
Flag Coverage Δ
#integrationtests ?
#unittests 49.9% <0%> (-12.31%) ⬇️
Impacted Files Coverage Δ
...ices/sidecar/src/simcore_service_sidecar/celery.py 0% <0%> (ø) ⬆️
...ices/sidecar/src/simcore_service_sidecar/config.py 0% <0%> (-100%) ⬇️
...es/sidecar/src/simcore_service_sidecar/rabbitmq.py 0% <0%> (-95.09%) ⬇️
services/sidecar/src/simcore_service_sidecar/db.py 0% <0%> (-92%) ⬇️
...vices/sidecar/src/simcore_service_sidecar/utils.py 0% <0%> (-87.18%) ⬇️
.../sidecar/src/simcore_service_sidecar/log_parser.py 0% <0%> (-84.22%) ⬇️
...rvices/sidecar/src/simcore_service_sidecar/core.py 0% <0%> (-81.23%) ⬇️
...ervices/sidecar/src/simcore_service_sidecar/cli.py 0% <0%> (-74.08%) ⬇️
...re-sdk/src/simcore_sdk/node_ports/serialization.py 24.61% <0%> (-56.93%) ⬇️
.../sidecar/src/simcore_service_sidecar/exceptions.py 0% <0%> (-55.56%) ⬇️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9725800...11a7371. Read the comment docs.

_task = app.send_task(
"comp.task", args=(user_id, project_id, _node_id), kwargs={}
)
log.exception("Uncaught exception")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR: could you perhaps specify a bit more about the nature of the exception :-) I am aware that the exception traceback is printed but still...

@sanderegg sanderegg merged commit ab6862b into ITISFoundation:master Mar 30, 2020
@sanderegg sanderegg deleted the bugfix/sidecar_bugs branch March 30, 2020 07:49
@sanderegg sanderegg linked an issue Apr 6, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

platform stability
3 participants