-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/check gather return exceptions #1360
Bugfix/check gather return exceptions #1360
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1360 +/- ##
==========================================
- Coverage 72.75% 72.66% -0.09%
==========================================
Files 201 201
Lines 8356 8414 +58
Branches 937 943 +6
==========================================
+ Hits 6079 6114 +35
- Misses 2005 2025 +20
- Partials 272 275 +3
Continue to review full report at Codecov.
|
…xception catching exceptions correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
services/web/server/src/simcore_service_webserver/socketio/handlers.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super
What do these changes do?
based on ideas here
Related issue number
How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)