Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/check gather return exceptions #1360

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 11, 2020

What do these changes do?

  • check returned exceptions from asyncio.gather
  • check future exceptions using a callback fct on futures to check if an exception occured and report it
    based on ideas here

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@sanderegg sanderegg requested a review from pcrespov March 11, 2020 11:41
@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #1360 into master will decrease coverage by 0.08%.
The diff coverage is 72.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1360      +/-   ##
==========================================
- Coverage   72.75%   72.66%   -0.09%     
==========================================
  Files         201      201              
  Lines        8356     8414      +58     
  Branches      937      943       +6     
==========================================
+ Hits         6079     6114      +35     
- Misses       2005     2025      +20     
- Partials      272      275       +3
Flag Coverage Δ
#integrationtests 57.55% <37.39%> (ø) ⬆️
#unittests 66.86% <66.89%> (-0.31%) ⬇️
Impacted Files Coverage Δ
...erver/src/simcore_service_webserver/storage_api.py 58.82% <ø> (+23.52%) ⬆️
...tor/src/simcore_service_director/registry_proxy.py 69.43% <0%> (-0.73%) ⬇️
...r/src/simcore_service_webserver/socketio/events.py 100% <100%> (ø) ⬆️
...ackages/service-library/src/servicelib/observer.py 90% <100%> (ø) ⬆️
...simcore_service_webserver/projects/projects_api.py 81.41% <100%> (+0.74%) ⬆️
...webserver/computation_comp_tasks_listening_task.py 71.42% <14.28%> (-6.16%) ⬇️
packages/service-library/src/servicelib/utils.py 66.66% <47.61%> (-33.34%) ⬇️
...ce_webserver/resource_manager/garbage_collector.py 87.5% <50%> (+0.26%) ⬆️
.../simcore_service_webserver/computation_handlers.py 88% <63.63%> (-7.35%) ⬇️
...simcore_service_webserver/director/director_api.py 55% <66.66%> (-1.67%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c700f28...363b20d. Read the comment docs.

@sanderegg sanderegg requested a review from odeimaiz March 11, 2020 12:39
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super

@pcrespov pcrespov merged commit 6ace13d into ITISFoundation:master Mar 12, 2020
@sanderegg sanderegg linked an issue Apr 6, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

platform stability
3 participants